From 0d532e911cb7e67e151153289024183bc4f5b257 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Tue, 2 Oct 2018 06:58:00 +0200 Subject: [PATCH] fs: fat: memory leak in fat_unlink() Do not leak filename_copy in case of error. Catch out of memory when calling strdup. Reported-by: Coverity (CID: 184086) Signed-off-by: Heinrich Schuchardt --- fs/fat/fat_write.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c index fc211e7..1ec72d1 100644 --- a/fs/fat/fat_write.c +++ b/fs/fat/fat_write.c @@ -1259,6 +1259,11 @@ int fat_unlink(const char *filename) char *filename_copy, *dirname, *basename; filename_copy = strdup(filename); + if (!filename_copy) { + printf("Error: allocating memory\n"); + ret = -ENOMEM; + goto exit; + } split_filename(filename_copy, &dirname, &basename); if (!strcmp(dirname, "/") && !strcmp(basename, "")) { @@ -1270,7 +1275,8 @@ int fat_unlink(const char *filename) itr = malloc_cache_aligned(sizeof(fat_itr)); if (!itr) { printf("Error: allocating memory\n"); - return -ENOMEM; + ret = -ENOMEM; + goto exit; } ret = fat_itr_root(itr, &fsdata);