From 58f680a47eab60bae335440ab4044f16b85273de Mon Sep 17 00:00:00 2001 From: Merlijn Wajer Date: Fri, 13 Apr 2018 22:31:42 +0200 Subject: [PATCH] Use a define for the chip version mask on the axp209. --- drivers/power/axp209.c | 3 +++ include/axp209.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/power/axp209.c b/drivers/power/axp209.c index 6de5ec6..52207e5 100644 --- a/drivers/power/axp209.c +++ b/drivers/power/axp209.c @@ -153,10 +153,13 @@ int axp_init(void) if (rc) return rc; +#if 0 /* Low 4 bits is chip version */ ver &= 0x0f; if (ver != 0x1) +#endif + if ((ver & AXP209_CHIP_VERSION_MASK) != 0x1) return -EINVAL; /* Mask all interrupts */ diff --git a/include/axp209.h b/include/axp209.h index 3a4fc28..43e3873 100644 --- a/include/axp209.h +++ b/include/axp209.h @@ -25,6 +25,8 @@ enum axp209_reg { #define AXP209_POWER_STATUS_ON_BY_DC BIT(0) #define AXP209_POWER_STATUS_VBUS_USABLE BIT(4) +#define AXP209_CHIP_VERSION_MASK 0x0f + #define AXP209_OUTPUT_CTRL_EXTEN BIT(0) #define AXP209_OUTPUT_CTRL_DCDC3 BIT(1) #define AXP209_OUTPUT_CTRL_LDO2 BIT(2)