From 741f2d620c3ff2d59d3b25c344ab6b8bec4a4c87 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Mon, 1 Oct 2018 12:22:30 -0600 Subject: [PATCH] binman: Move to three-digit test-file numbers We now have 99 tests. Before adding any more, rename everything to three digits. This helps to preserve the ordering of tests and makes it easier to find things. Signed-off-by: Simon Glass --- tools/binman/entry_test.py | 2 +- tools/binman/fdt_test.py | 4 +- tools/binman/ftest.py | 224 ++++++++++----------- .../test/{01_invalid.dts => 001_invalid.dts} | 0 .../{02_missing_node.dts => 002_missing_node.dts} | 0 tools/binman/test/{03_empty.dts => 003_empty.dts} | 0 ...{04_invalid_entry.dts => 004_invalid_entry.dts} | 0 .../binman/test/{05_simple.dts => 005_simple.dts} | 0 .../test/{06_dual_image.dts => 006_dual_image.dts} | 0 .../test/{07_bad_align.dts => 007_bad_align.dts} | 0 tools/binman/test/{08_pack.dts => 008_pack.dts} | 0 .../test/{09_pack_extra.dts => 009_pack_extra.dts} | 0 ..._align_power2.dts => 010_pack_align_power2.dts} | 0 ...e_power2.dts => 011_pack_align_size_power2.dts} | 0 ...2_pack_inv_align.dts => 012_pack_inv_align.dts} | 0 ..._size_align.dts => 013_pack_inv_size_align.dts} | 0 .../{14_pack_overlap.dts => 014_pack_overlap.dts} | 0 ...{15_pack_overflow.dts => 015_pack_overflow.dts} | 0 ...ge_overflow.dts => 016_pack_image_overflow.dts} | 0 ...pack_image_size.dts => 017_pack_image_size.dts} | 0 ...ck_image_align.dts => 018_pack_image_align.dts} | 0 ...mage_align.dts => 019_pack_inv_image_align.dts} | 0 ...er2.dts => 020_pack_inv_image_align_power2.dts} | 0 .../test/{21_image_pad.dts => 021_image_pad.dts} | 0 .../test/{22_image_name.dts => 022_image_name.dts} | 0 tools/binman/test/{23_blob.dts => 023_blob.dts} | 0 .../binman/test/{24_sorted.dts => 024_sorted.dts} | 0 ...5_pack_zero_size.dts => 025_pack_zero_size.dts} | 0 ...pack_u_boot_dtb.dts => 026_pack_u_boot_dtb.dts} | 0 ...ck_4gb_no_size.dts => 027_pack_4gb_no_size.dts} | 0 ...ck_4gb_outside.dts => 028_pack_4gb_outside.dts} | 0 .../test/{29_x86-rom.dts => 029_x86-rom.dts} | 0 ...m-me-no-desc.dts => 030_x86-rom-me-no-desc.dts} | 0 .../test/{31_x86-rom-me.dts => 031_x86-rom-me.dts} | 0 .../test/{32_intel-vga.dts => 032_intel-vga.dts} | 0 .../{33_x86-start16.dts => 033_x86-start16.dts} | 0 .../test/{34_x86_ucode.dts => 034_x86_ucode.dts} | 0 ...6_single_ucode.dts => 035_x86_single_ucode.dts} | 0 .../test/{36_u_boot_img.dts => 036_u_boot_img.dts} | 0 .../{37_x86_no_ucode.dts => 037_x86_no_ucode.dts} | 0 ...ing_node.dts => 038_x86_ucode_missing_node.dts} | 0 ...g_node2.dts => 039_x86_ucode_missing_node2.dts} | 0 ...in_image.dts => 040_x86_ucode_not_in_image.dts} | 0 ...known_pos_size.dts => 041_unknown_pos_size.dts} | 0 .../test/{42_intel-fsp.dts => 042_intel-fsp.dts} | 0 .../test/{43_intel-cmc.dts => 043_intel-cmc.dts} | 0 ...tional_ucode.dts => 044_x86_optional_ucode.dts} | 0 .../test/{45_prop_test.dts => 045_prop_test.dts} | 0 .../test/{46_intel-vbt.dts => 046_intel-vbt.dts} | 0 .../{47_spl_bss_pad.dts => 047_spl_bss_pad.dts} | 0 ...x86-start16-spl.dts => 048_x86-start16-spl.dts} | 0 ...{49_x86_ucode_spl.dts => 049_x86_ucode_spl.dts} | 0 .../test/{50_intel_mrc.dts => 050_intel_mrc.dts} | 0 ...1_u_boot_spl_dtb.dts => 051_u_boot_spl_dtb.dts} | 0 ...boot_spl_nodtb.dts => 052_u_boot_spl_nodtb.dts} | 0 .../test/{53_symbols.dts => 053_symbols.dts} | 0 .../{54_unit_address.dts => 054_unit_address.dts} | 0 .../test/{55_sections.dts => 055_sections.dts} | 0 .../{56_name_prefix.dts => 056_name_prefix.dts} | 0 ...known_contents.dts => 057_unknown_contents.dts} | 0 ...retry.dts => 058_x86_ucode_spl_needs_retry.dts} | 0 .../{59_change_size.dts => 059_change_size.dts} | 0 .../test/{60_fdt_update.dts => 060_fdt_update.dts} | 0 ...1_fdt_update_bad.dts => 061_fdt_update_bad.dts} | 0 .../test/{62_entry_args.dts => 062_entry_args.dts} | 0 ...args_missing.dts => 063_entry_args_missing.dts} | 0 ...gs_required.dts => 064_entry_args_required.dts} | 0 ...ype.dts => 065_entry_args_unknown_datatype.dts} | 0 tools/binman/test/{66_text.dts => 066_text.dts} | 0 tools/binman/test/{67_fmap.dts => 067_fmap.dts} | 0 ..._named_by_arg.dts => 068_blob_named_by_arg.dts} | 0 tools/binman/test/{69_fill.dts => 069_fill.dts} | 0 .../{70_fill_no_size.dts => 070_fill_no_size.dts} | 0 tools/binman/test/{71_gbb.dts => 071_gbb.dts} | 0 ...{72_gbb_too_small.dts => 072_gbb_too_small.dts} | 0 .../{73_gbb_no_size.dts => 073_gbb_no_size.dts} | 0 .../binman/test/{74_vblock.dts => 074_vblock.dts} | 0 ...ck_no_content.dts => 075_vblock_no_content.dts} | 0 ..._bad_phandle.dts => 076_vblock_bad_phandle.dts} | 0 ...lock_bad_entry.dts => 077_vblock_bad_entry.dts} | 0 .../test/{78_u_boot_tpl.dts => 078_u_boot_tpl.dts} | 0 .../test/{79_uses_pos.dts => 079_uses_pos.dts} | 0 .../test/{80_fill_empty.dts => 080_fill_empty.dts} | 0 ...x86-start16-tpl.dts => 081_x86-start16-tpl.dts} | 0 ...2_fdt_update_all.dts => 082_fdt_update_all.dts} | 0 .../test/{83_compress.dts => 083_compress.dts} | 0 tools/binman/test/{84_files.dts => 084_files.dts} | 0 ...5_files_compress.dts => 085_files_compress.dts} | 0 .../test/{86_files_none.dts => 086_files_none.dts} | 0 ...les_no_pattern.dts => 087_files_no_pattern.dts} | 0 .../{88_expand_size.dts => 088_expand_size.dts} | 0 ...expand_size_bad.dts => 089_expand_size_bad.dts} | 0 tools/binman/test/{90_hash.dts => 090_hash.dts} | 0 .../{91_hash_no_algo.dts => 091_hash_no_algo.dts} | 0 ...{92_hash_bad_algo.dts => 092_hash_bad_algo.dts} | 0 ...{93_x86_tpl_ucode.dts => 093_x86_tpl_ucode.dts} | 0 .../test/{94_fmap_x86.dts => 094_fmap_x86.dts} | 0 ...ap_x86_section.dts => 095_fmap_x86_section.dts} | 0 tools/binman/test/{96_elf.dts => 096_elf.dts} | 0 .../test/{97_elf_strip.dts => 097_elf_strip.dts} | 0 .../{99_hash_section.dts => 099_hash_section.dts} | 0 101 files changed, 115 insertions(+), 115 deletions(-) rename tools/binman/test/{01_invalid.dts => 001_invalid.dts} (100%) rename tools/binman/test/{02_missing_node.dts => 002_missing_node.dts} (100%) rename tools/binman/test/{03_empty.dts => 003_empty.dts} (100%) rename tools/binman/test/{04_invalid_entry.dts => 004_invalid_entry.dts} (100%) rename tools/binman/test/{05_simple.dts => 005_simple.dts} (100%) rename tools/binman/test/{06_dual_image.dts => 006_dual_image.dts} (100%) rename tools/binman/test/{07_bad_align.dts => 007_bad_align.dts} (100%) rename tools/binman/test/{08_pack.dts => 008_pack.dts} (100%) rename tools/binman/test/{09_pack_extra.dts => 009_pack_extra.dts} (100%) rename tools/binman/test/{10_pack_align_power2.dts => 010_pack_align_power2.dts} (100%) rename tools/binman/test/{11_pack_align_size_power2.dts => 011_pack_align_size_power2.dts} (100%) rename tools/binman/test/{12_pack_inv_align.dts => 012_pack_inv_align.dts} (100%) rename tools/binman/test/{13_pack_inv_size_align.dts => 013_pack_inv_size_align.dts} (100%) rename tools/binman/test/{14_pack_overlap.dts => 014_pack_overlap.dts} (100%) rename tools/binman/test/{15_pack_overflow.dts => 015_pack_overflow.dts} (100%) rename tools/binman/test/{16_pack_image_overflow.dts => 016_pack_image_overflow.dts} (100%) rename tools/binman/test/{17_pack_image_size.dts => 017_pack_image_size.dts} (100%) rename tools/binman/test/{18_pack_image_align.dts => 018_pack_image_align.dts} (100%) rename tools/binman/test/{19_pack_inv_image_align.dts => 019_pack_inv_image_align.dts} (100%) rename tools/binman/test/{20_pack_inv_image_align_power2.dts => 020_pack_inv_image_align_power2.dts} (100%) rename tools/binman/test/{21_image_pad.dts => 021_image_pad.dts} (100%) rename tools/binman/test/{22_image_name.dts => 022_image_name.dts} (100%) rename tools/binman/test/{23_blob.dts => 023_blob.dts} (100%) rename tools/binman/test/{24_sorted.dts => 024_sorted.dts} (100%) rename tools/binman/test/{25_pack_zero_size.dts => 025_pack_zero_size.dts} (100%) rename tools/binman/test/{26_pack_u_boot_dtb.dts => 026_pack_u_boot_dtb.dts} (100%) rename tools/binman/test/{27_pack_4gb_no_size.dts => 027_pack_4gb_no_size.dts} (100%) rename tools/binman/test/{28_pack_4gb_outside.dts => 028_pack_4gb_outside.dts} (100%) rename tools/binman/test/{29_x86-rom.dts => 029_x86-rom.dts} (100%) rename tools/binman/test/{30_x86-rom-me-no-desc.dts => 030_x86-rom-me-no-desc.dts} (100%) rename tools/binman/test/{31_x86-rom-me.dts => 031_x86-rom-me.dts} (100%) rename tools/binman/test/{32_intel-vga.dts => 032_intel-vga.dts} (100%) rename tools/binman/test/{33_x86-start16.dts => 033_x86-start16.dts} (100%) rename tools/binman/test/{34_x86_ucode.dts => 034_x86_ucode.dts} (100%) rename tools/binman/test/{35_x86_single_ucode.dts => 035_x86_single_ucode.dts} (100%) rename tools/binman/test/{36_u_boot_img.dts => 036_u_boot_img.dts} (100%) rename tools/binman/test/{37_x86_no_ucode.dts => 037_x86_no_ucode.dts} (100%) rename tools/binman/test/{38_x86_ucode_missing_node.dts => 038_x86_ucode_missing_node.dts} (100%) rename tools/binman/test/{39_x86_ucode_missing_node2.dts => 039_x86_ucode_missing_node2.dts} (100%) rename tools/binman/test/{40_x86_ucode_not_in_image.dts => 040_x86_ucode_not_in_image.dts} (100%) rename tools/binman/test/{41_unknown_pos_size.dts => 041_unknown_pos_size.dts} (100%) rename tools/binman/test/{42_intel-fsp.dts => 042_intel-fsp.dts} (100%) rename tools/binman/test/{43_intel-cmc.dts => 043_intel-cmc.dts} (100%) rename tools/binman/test/{44_x86_optional_ucode.dts => 044_x86_optional_ucode.dts} (100%) rename tools/binman/test/{45_prop_test.dts => 045_prop_test.dts} (100%) rename tools/binman/test/{46_intel-vbt.dts => 046_intel-vbt.dts} (100%) rename tools/binman/test/{47_spl_bss_pad.dts => 047_spl_bss_pad.dts} (100%) rename tools/binman/test/{48_x86-start16-spl.dts => 048_x86-start16-spl.dts} (100%) rename tools/binman/test/{49_x86_ucode_spl.dts => 049_x86_ucode_spl.dts} (100%) rename tools/binman/test/{50_intel_mrc.dts => 050_intel_mrc.dts} (100%) rename tools/binman/test/{51_u_boot_spl_dtb.dts => 051_u_boot_spl_dtb.dts} (100%) rename tools/binman/test/{52_u_boot_spl_nodtb.dts => 052_u_boot_spl_nodtb.dts} (100%) rename tools/binman/test/{53_symbols.dts => 053_symbols.dts} (100%) rename tools/binman/test/{54_unit_address.dts => 054_unit_address.dts} (100%) rename tools/binman/test/{55_sections.dts => 055_sections.dts} (100%) rename tools/binman/test/{56_name_prefix.dts => 056_name_prefix.dts} (100%) rename tools/binman/test/{57_unknown_contents.dts => 057_unknown_contents.dts} (100%) rename tools/binman/test/{58_x86_ucode_spl_needs_retry.dts => 058_x86_ucode_spl_needs_retry.dts} (100%) rename tools/binman/test/{59_change_size.dts => 059_change_size.dts} (100%) rename tools/binman/test/{60_fdt_update.dts => 060_fdt_update.dts} (100%) rename tools/binman/test/{61_fdt_update_bad.dts => 061_fdt_update_bad.dts} (100%) rename tools/binman/test/{62_entry_args.dts => 062_entry_args.dts} (100%) rename tools/binman/test/{63_entry_args_missing.dts => 063_entry_args_missing.dts} (100%) rename tools/binman/test/{64_entry_args_required.dts => 064_entry_args_required.dts} (100%) rename tools/binman/test/{65_entry_args_unknown_datatype.dts => 065_entry_args_unknown_datatype.dts} (100%) rename tools/binman/test/{66_text.dts => 066_text.dts} (100%) rename tools/binman/test/{67_fmap.dts => 067_fmap.dts} (100%) rename tools/binman/test/{68_blob_named_by_arg.dts => 068_blob_named_by_arg.dts} (100%) rename tools/binman/test/{69_fill.dts => 069_fill.dts} (100%) rename tools/binman/test/{70_fill_no_size.dts => 070_fill_no_size.dts} (100%) rename tools/binman/test/{71_gbb.dts => 071_gbb.dts} (100%) rename tools/binman/test/{72_gbb_too_small.dts => 072_gbb_too_small.dts} (100%) rename tools/binman/test/{73_gbb_no_size.dts => 073_gbb_no_size.dts} (100%) rename tools/binman/test/{74_vblock.dts => 074_vblock.dts} (100%) rename tools/binman/test/{75_vblock_no_content.dts => 075_vblock_no_content.dts} (100%) rename tools/binman/test/{76_vblock_bad_phandle.dts => 076_vblock_bad_phandle.dts} (100%) rename tools/binman/test/{77_vblock_bad_entry.dts => 077_vblock_bad_entry.dts} (100%) rename tools/binman/test/{78_u_boot_tpl.dts => 078_u_boot_tpl.dts} (100%) rename tools/binman/test/{79_uses_pos.dts => 079_uses_pos.dts} (100%) rename tools/binman/test/{80_fill_empty.dts => 080_fill_empty.dts} (100%) rename tools/binman/test/{81_x86-start16-tpl.dts => 081_x86-start16-tpl.dts} (100%) rename tools/binman/test/{82_fdt_update_all.dts => 082_fdt_update_all.dts} (100%) rename tools/binman/test/{83_compress.dts => 083_compress.dts} (100%) rename tools/binman/test/{84_files.dts => 084_files.dts} (100%) rename tools/binman/test/{85_files_compress.dts => 085_files_compress.dts} (100%) rename tools/binman/test/{86_files_none.dts => 086_files_none.dts} (100%) rename tools/binman/test/{87_files_no_pattern.dts => 087_files_no_pattern.dts} (100%) rename tools/binman/test/{88_expand_size.dts => 088_expand_size.dts} (100%) rename tools/binman/test/{89_expand_size_bad.dts => 089_expand_size_bad.dts} (100%) rename tools/binman/test/{90_hash.dts => 090_hash.dts} (100%) rename tools/binman/test/{91_hash_no_algo.dts => 091_hash_no_algo.dts} (100%) rename tools/binman/test/{92_hash_bad_algo.dts => 092_hash_bad_algo.dts} (100%) rename tools/binman/test/{93_x86_tpl_ucode.dts => 093_x86_tpl_ucode.dts} (100%) rename tools/binman/test/{94_fmap_x86.dts => 094_fmap_x86.dts} (100%) rename tools/binman/test/{95_fmap_x86_section.dts => 095_fmap_x86_section.dts} (100%) rename tools/binman/test/{96_elf.dts => 096_elf.dts} (100%) rename tools/binman/test/{97_elf_strip.dts => 097_elf_strip.dts} (100%) rename tools/binman/test/{99_hash_section.dts => 099_hash_section.dts} (100%) diff --git a/tools/binman/entry_test.py b/tools/binman/entry_test.py index 17ab229..1f7ff5b 100644 --- a/tools/binman/entry_test.py +++ b/tools/binman/entry_test.py @@ -25,7 +25,7 @@ class TestEntry(unittest.TestCase): def GetNode(self): binman_dir = os.path.dirname(os.path.realpath(sys.argv[0])) fname = fdt_util.EnsureCompiled( - os.path.join(binman_dir,('test/05_simple.dts'))) + os.path.join(binman_dir,('test/005_simple.dts'))) dtb = fdt.FdtScan(fname) return dtb.GetNode('/binman/u-boot') diff --git a/tools/binman/fdt_test.py b/tools/binman/fdt_test.py index b916701..ac6f910 100644 --- a/tools/binman/fdt_test.py +++ b/tools/binman/fdt_test.py @@ -36,12 +36,12 @@ class TestFdt(unittest.TestCase): node.DeleteProp('data') def testFdtNormal(self): - fname = self.GetCompiled('34_x86_ucode.dts') + fname = self.GetCompiled('034_x86_ucode.dts') dt = FdtScan(fname) self._DeleteProp(dt) def testFdtNormalProp(self): - fname = self.GetCompiled('45_prop_test.dts') + fname = self.GetCompiled('045_prop_test.dts') dt = FdtScan(fname) node = dt.GetNode('/binman/intel-me') self.assertEquals('intel-me', node.name) diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index 9f21027..167f56d 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -189,7 +189,7 @@ class TestFunctional(unittest.TestCase): """Run binman with a given test file Args: - fname: Device-tree source filename to use (e.g. 05_simple.dts) + fname: Device-tree source filename to use (e.g. 005_simple.dts) debug: True to enable debugging output map: True to output map files for the images update_dtb: Update the offset and size of each entry in the device @@ -266,7 +266,7 @@ class TestFunctional(unittest.TestCase): Raises an assertion failure if binman returns a non-zero exit code. Args: - fname: Device-tree source filename to use (e.g. 05_simple.dts) + fname: Device-tree source filename to use (e.g. 005_simple.dts) use_real_dtb: True to use the test file as the contents of the u-boot-dtb entry. Normally this is not needed and the test contents (the U_BOOT_DTB_DATA string) can be used. @@ -323,7 +323,7 @@ class TestFunctional(unittest.TestCase): """Helper function which discards the device-tree binary Args: - fname: Device-tree source filename to use (e.g. 05_simple.dts) + fname: Device-tree source filename to use (e.g. 005_simple.dts) use_real_dtb: True to use the test file as the contents of the u-boot-dtb entry. Normally this is not needed and the test contents (the U_BOOT_DTB_DATA string) can be used. @@ -464,7 +464,7 @@ class TestFunctional(unittest.TestCase): def testBoard(self): """Test that we can run it with a specific board""" - self._SetupDtb('05_simple.dts', 'sandbox/u-boot.dtb') + self._SetupDtb('005_simple.dts', 'sandbox/u-boot.dtb') TestFunctional._MakeInputFile('sandbox/u-boot.bin', U_BOOT_DATA) result = self._DoBinman('-b', 'sandbox') self.assertEqual(0, result) @@ -491,19 +491,19 @@ class TestFunctional(unittest.TestCase): will come from the device-tree compiler (dtc). """ with self.assertRaises(Exception) as e: - self._RunBinman('-d', self.TestFile('01_invalid.dts')) + self._RunBinman('-d', self.TestFile('001_invalid.dts')) self.assertIn("FATAL ERROR: Unable to parse input tree", str(e.exception)) def testMissingNode(self): """Test that a device tree without a 'binman' node generates an error""" with self.assertRaises(Exception) as e: - self._DoBinman('-d', self.TestFile('02_missing_node.dts')) + self._DoBinman('-d', self.TestFile('002_missing_node.dts')) self.assertIn("does not have a 'binman' node", str(e.exception)) def testEmpty(self): """Test that an empty binman node works OK (i.e. does nothing)""" - result = self._RunBinman('-d', self.TestFile('03_empty.dts')) + result = self._RunBinman('-d', self.TestFile('003_empty.dts')) self.assertEqual(0, len(result.stderr)) self.assertEqual(0, result.return_code) @@ -511,25 +511,25 @@ class TestFunctional(unittest.TestCase): """Test that an invalid entry is flagged""" with self.assertRaises(Exception) as e: result = self._RunBinman('-d', - self.TestFile('04_invalid_entry.dts')) + self.TestFile('004_invalid_entry.dts')) self.assertIn("Unknown entry type 'not-a-valid-type' in node " "'/binman/not-a-valid-type'", str(e.exception)) def testSimple(self): """Test a simple binman with a single file""" - data = self._DoReadFile('05_simple.dts') + data = self._DoReadFile('005_simple.dts') self.assertEqual(U_BOOT_DATA, data) def testSimpleDebug(self): """Test a simple binman run with debugging enabled""" - data = self._DoTestFile('05_simple.dts', debug=True) + data = self._DoTestFile('005_simple.dts', debug=True) def testDual(self): """Test that we can handle creating two images This also tests image padding. """ - retcode = self._DoTestFile('06_dual_image.dts') + retcode = self._DoTestFile('006_dual_image.dts') self.assertEqual(0, retcode) image = control.images['image1'] @@ -553,13 +553,13 @@ class TestFunctional(unittest.TestCase): def testBadAlign(self): """Test that an invalid alignment value is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('07_bad_align.dts') + self._DoTestFile('007_bad_align.dts') self.assertIn("Node '/binman/u-boot': Alignment 23 must be a power " "of two", str(e.exception)) def testPackSimple(self): """Test that packing works as expected""" - retcode = self._DoTestFile('08_pack.dts') + retcode = self._DoTestFile('008_pack.dts') self.assertEqual(0, retcode) self.assertIn('image', control.images) image = control.images['image'] @@ -601,7 +601,7 @@ class TestFunctional(unittest.TestCase): def testPackExtra(self): """Test that extra packing feature works as expected""" - retcode = self._DoTestFile('09_pack_extra.dts') + retcode = self._DoTestFile('009_pack_extra.dts') self.assertEqual(0, retcode) self.assertIn('image', control.images) @@ -646,35 +646,35 @@ class TestFunctional(unittest.TestCase): def testPackAlignPowerOf2(self): """Test that invalid entry alignment is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('10_pack_align_power2.dts') + self._DoTestFile('010_pack_align_power2.dts') self.assertIn("Node '/binman/u-boot': Alignment 5 must be a power " "of two", str(e.exception)) def testPackAlignSizePowerOf2(self): """Test that invalid entry size alignment is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('11_pack_align_size_power2.dts') + self._DoTestFile('011_pack_align_size_power2.dts') self.assertIn("Node '/binman/u-boot': Alignment size 55 must be a " "power of two", str(e.exception)) def testPackInvalidAlign(self): """Test detection of an offset that does not match its alignment""" with self.assertRaises(ValueError) as e: - self._DoTestFile('12_pack_inv_align.dts') + self._DoTestFile('012_pack_inv_align.dts') self.assertIn("Node '/binman/u-boot': Offset 0x5 (5) does not match " "align 0x4 (4)", str(e.exception)) def testPackInvalidSizeAlign(self): """Test that invalid entry size alignment is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('13_pack_inv_size_align.dts') + self._DoTestFile('013_pack_inv_size_align.dts') self.assertIn("Node '/binman/u-boot': Size 0x5 (5) does not match " "align-size 0x4 (4)", str(e.exception)) def testPackOverlap(self): """Test that overlapping regions are detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('14_pack_overlap.dts') + self._DoTestFile('014_pack_overlap.dts') self.assertIn("Node '/binman/u-boot-align': Offset 0x3 (3) overlaps " "with previous entry '/binman/u-boot' ending at 0x4 (4)", str(e.exception)) @@ -682,20 +682,20 @@ class TestFunctional(unittest.TestCase): def testPackEntryOverflow(self): """Test that entries that overflow their size are detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('15_pack_overflow.dts') + self._DoTestFile('015_pack_overflow.dts') self.assertIn("Node '/binman/u-boot': Entry contents size is 0x4 (4) " "but entry size is 0x3 (3)", str(e.exception)) def testPackImageOverflow(self): """Test that entries which overflow the image size are detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('16_pack_image_overflow.dts') + self._DoTestFile('016_pack_image_overflow.dts') self.assertIn("Section '/binman': contents size 0x4 (4) exceeds section " "size 0x3 (3)", str(e.exception)) def testPackImageSize(self): """Test that the image size can be set""" - retcode = self._DoTestFile('17_pack_image_size.dts') + retcode = self._DoTestFile('017_pack_image_size.dts') self.assertEqual(0, retcode) self.assertIn('image', control.images) image = control.images['image'] @@ -703,7 +703,7 @@ class TestFunctional(unittest.TestCase): def testPackImageSizeAlign(self): """Test that image size alignemnt works as expected""" - retcode = self._DoTestFile('18_pack_image_align.dts') + retcode = self._DoTestFile('018_pack_image_align.dts') self.assertEqual(0, retcode) self.assertIn('image', control.images) image = control.images['image'] @@ -712,26 +712,26 @@ class TestFunctional(unittest.TestCase): def testPackInvalidImageAlign(self): """Test that invalid image alignment is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('19_pack_inv_image_align.dts') + self._DoTestFile('019_pack_inv_image_align.dts') self.assertIn("Section '/binman': Size 0x7 (7) does not match " "align-size 0x8 (8)", str(e.exception)) def testPackAlignPowerOf2(self): """Test that invalid image alignment is detected""" with self.assertRaises(ValueError) as e: - self._DoTestFile('20_pack_inv_image_align_power2.dts') + self._DoTestFile('020_pack_inv_image_align_power2.dts') self.assertIn("Section '/binman': Alignment size 131 must be a power of " "two", str(e.exception)) def testImagePadByte(self): """Test that the image pad byte can be specified""" self._SetupSplElf() - data = self._DoReadFile('21_image_pad.dts') + data = self._DoReadFile('021_image_pad.dts') self.assertEqual(U_BOOT_SPL_DATA + (chr(0xff) * 1) + U_BOOT_DATA, data) def testImageName(self): """Test that image files can be named""" - retcode = self._DoTestFile('22_image_name.dts') + retcode = self._DoTestFile('022_image_name.dts') self.assertEqual(0, retcode) image = control.images['image1'] fname = tools.GetOutputFilename('test-name') @@ -743,33 +743,33 @@ class TestFunctional(unittest.TestCase): def testBlobFilename(self): """Test that generic blobs can be provided by filename""" - data = self._DoReadFile('23_blob.dts') + data = self._DoReadFile('023_blob.dts') self.assertEqual(BLOB_DATA, data) def testPackSorted(self): """Test that entries can be sorted""" self._SetupSplElf() - data = self._DoReadFile('24_sorted.dts') + data = self._DoReadFile('024_sorted.dts') self.assertEqual(chr(0) * 1 + U_BOOT_SPL_DATA + chr(0) * 2 + U_BOOT_DATA, data) def testPackZeroOffset(self): """Test that an entry at offset 0 is not given a new offset""" with self.assertRaises(ValueError) as e: - self._DoTestFile('25_pack_zero_size.dts') + self._DoTestFile('025_pack_zero_size.dts') self.assertIn("Node '/binman/u-boot-spl': Offset 0x0 (0) overlaps " "with previous entry '/binman/u-boot' ending at 0x4 (4)", str(e.exception)) def testPackUbootDtb(self): """Test that a device tree can be added to U-Boot""" - data = self._DoReadFile('26_pack_u_boot_dtb.dts') + data = self._DoReadFile('026_pack_u_boot_dtb.dts') self.assertEqual(U_BOOT_NODTB_DATA + U_BOOT_DTB_DATA, data) def testPackX86RomNoSize(self): """Test that the end-at-4gb property requires a size property""" with self.assertRaises(ValueError) as e: - self._DoTestFile('27_pack_4gb_no_size.dts') + self._DoTestFile('027_pack_4gb_no_size.dts') self.assertIn("Section '/binman': Section size must be provided when " "using end-at-4gb", str(e.exception)) @@ -784,7 +784,7 @@ class TestFunctional(unittest.TestCase): def testPackX86RomOutside(self): """Test that the end-at-4gb property checks for offset boundaries""" with self.assertRaises(ValueError) as e: - self._DoTestFile('28_pack_4gb_outside.dts') + self._DoTestFile('028_pack_4gb_outside.dts') self.assertIn("Node '/binman/u-boot': Offset 0x0 (0) is outside " "the section starting at 0xffffffe0 (4294967264)", str(e.exception)) @@ -792,7 +792,7 @@ class TestFunctional(unittest.TestCase): def testPackX86Rom(self): """Test that a basic x86 ROM can be created""" self._SetupSplElf() - data = self._DoReadFile('29_x86-rom.dts') + data = self._DoReadFile('029_x86-rom.dts') self.assertEqual(U_BOOT_DATA + chr(0) * 7 + U_BOOT_SPL_DATA + chr(0) * 2, data) @@ -800,31 +800,31 @@ class TestFunctional(unittest.TestCase): """Test that an invalid Intel descriptor entry is detected""" TestFunctional._MakeInputFile('descriptor.bin', '') with self.assertRaises(ValueError) as e: - self._DoTestFile('31_x86-rom-me.dts') + self._DoTestFile('031_x86-rom-me.dts') self.assertIn("Node '/binman/intel-descriptor': Cannot find FD " "signature", str(e.exception)) def testPackX86RomBadDesc(self): """Test that the Intel requires a descriptor entry""" with self.assertRaises(ValueError) as e: - self._DoTestFile('30_x86-rom-me-no-desc.dts') + self._DoTestFile('030_x86-rom-me-no-desc.dts') self.assertIn("Node '/binman/intel-me': No offset set with " "offset-unset: should another entry provide this correct " "offset?", str(e.exception)) def testPackX86RomMe(self): """Test that an x86 ROM with an ME region can be created""" - data = self._DoReadFile('31_x86-rom-me.dts') + data = self._DoReadFile('031_x86-rom-me.dts') self.assertEqual(ME_DATA, data[0x1000:0x1000 + len(ME_DATA)]) def testPackVga(self): """Test that an image with a VGA binary can be created""" - data = self._DoReadFile('32_intel-vga.dts') + data = self._DoReadFile('032_intel-vga.dts') self.assertEqual(VGA_DATA, data[:len(VGA_DATA)]) def testPackStart16(self): """Test that an image with an x86 start16 region can be created""" - data = self._DoReadFile('33_x86-start16.dts') + data = self._DoReadFile('033_x86-start16.dts') self.assertEqual(X86_START16_DATA, data[:len(X86_START16_DATA)]) def testPackPowerpcMpc85xxBootpgResetvec(self): @@ -893,7 +893,7 @@ class TestFunctional(unittest.TestCase): u-boot.dtb with the microcode removed the microcode """ - first, pos_and_size = self._RunMicrocodeTest('34_x86_ucode.dts', + first, pos_and_size = self._RunMicrocodeTest('034_x86_ucode.dts', U_BOOT_NODTB_DATA) self.assertEqual('nodtb with microcode' + pos_and_size + ' somewhere in here', first) @@ -910,7 +910,7 @@ class TestFunctional(unittest.TestCase): # We need the libfdt library to run this test since only that allows # finding the offset of a property. This is required by # Entry_u_boot_dtb_with_ucode.ObtainContents(). - data = self._DoReadFile('35_x86_single_ucode.dts', True) + data = self._DoReadFile('035_x86_single_ucode.dts', True) second = data[len(U_BOOT_NODTB_DATA):] @@ -937,27 +937,27 @@ class TestFunctional(unittest.TestCase): def testUBootImg(self): """Test that u-boot.img can be put in a file""" - data = self._DoReadFile('36_u_boot_img.dts') + data = self._DoReadFile('036_u_boot_img.dts') self.assertEqual(U_BOOT_IMG_DATA, data) def testNoMicrocode(self): """Test that a missing microcode region is detected""" with self.assertRaises(ValueError) as e: - self._DoReadFile('37_x86_no_ucode.dts', True) + self._DoReadFile('037_x86_no_ucode.dts', True) self.assertIn("Node '/binman/u-boot-dtb-with-ucode': No /microcode " "node found in ", str(e.exception)) def testMicrocodeWithoutNode(self): """Test that a missing u-boot-dtb-with-ucode node is detected""" with self.assertRaises(ValueError) as e: - self._DoReadFile('38_x86_ucode_missing_node.dts', True) + self._DoReadFile('038_x86_ucode_missing_node.dts', True) self.assertIn("Node '/binman/u-boot-with-ucode-ptr': Cannot find " "microcode region u-boot-dtb-with-ucode", str(e.exception)) def testMicrocodeWithoutNode2(self): """Test that a missing u-boot-ucode node is detected""" with self.assertRaises(ValueError) as e: - self._DoReadFile('39_x86_ucode_missing_node2.dts', True) + self._DoReadFile('039_x86_ucode_missing_node2.dts', True) self.assertIn("Node '/binman/u-boot-with-ucode-ptr': Cannot find " "microcode region u-boot-ucode", str(e.exception)) @@ -981,7 +981,7 @@ class TestFunctional(unittest.TestCase): def testMicrocodeNotInImage(self): """Test that microcode must be placed within the image""" with self.assertRaises(ValueError) as e: - self._DoReadFile('40_x86_ucode_not_in_image.dts', True) + self._DoReadFile('040_x86_ucode_not_in_image.dts', True) self.assertIn("Node '/binman/u-boot-with-ucode-ptr': Microcode " "pointer _dt_ucode_base_size at fffffe14 is outside the " "section ranging from 00000000 to 0000002e", str(e.exception)) @@ -990,7 +990,7 @@ class TestFunctional(unittest.TestCase): """Test that we can cope with an image without microcode (e.g. qemu)""" with open(self.TestFile('u_boot_no_ucode_ptr')) as fd: TestFunctional._MakeInputFile('u-boot', fd.read()) - data, dtb, _, _ = self._DoReadFileDtb('44_x86_optional_ucode.dts', True) + data, dtb, _, _ = self._DoReadFileDtb('044_x86_optional_ucode.dts', True) # Now check the device tree has no microcode self.assertEqual(U_BOOT_NODTB_DATA, data[:len(U_BOOT_NODTB_DATA)]) @@ -1006,43 +1006,43 @@ class TestFunctional(unittest.TestCase): def testUnknownPosSize(self): """Test that microcode must be placed within the image""" with self.assertRaises(ValueError) as e: - self._DoReadFile('41_unknown_pos_size.dts', True) + self._DoReadFile('041_unknown_pos_size.dts', True) self.assertIn("Section '/binman': Unable to set offset/size for unknown " "entry 'invalid-entry'", str(e.exception)) def testPackFsp(self): """Test that an image with a FSP binary can be created""" - data = self._DoReadFile('42_intel-fsp.dts') + data = self._DoReadFile('042_intel-fsp.dts') self.assertEqual(FSP_DATA, data[:len(FSP_DATA)]) def testPackCmc(self): """Test that an image with a CMC binary can be created""" - data = self._DoReadFile('43_intel-cmc.dts') + data = self._DoReadFile('043_intel-cmc.dts') self.assertEqual(CMC_DATA, data[:len(CMC_DATA)]) def testPackVbt(self): """Test that an image with a VBT binary can be created""" - data = self._DoReadFile('46_intel-vbt.dts') + data = self._DoReadFile('046_intel-vbt.dts') self.assertEqual(VBT_DATA, data[:len(VBT_DATA)]) def testSplBssPad(self): """Test that we can pad SPL's BSS with zeros""" # ELF file with a '__bss_size' symbol self._SetupSplElf() - data = self._DoReadFile('47_spl_bss_pad.dts') + data = self._DoReadFile('047_spl_bss_pad.dts') self.assertEqual(U_BOOT_SPL_DATA + (chr(0) * 10) + U_BOOT_DATA, data) def testSplBssPadMissing(self): """Test that a missing symbol is detected""" self._SetupSplElf('u_boot_ucode_ptr') with self.assertRaises(ValueError) as e: - self._DoReadFile('47_spl_bss_pad.dts') + self._DoReadFile('047_spl_bss_pad.dts') self.assertIn('Expected __bss_size symbol in spl/u-boot-spl', str(e.exception)) def testPackStart16Spl(self): """Test that an image with an x86 start16 SPL region can be created""" - data = self._DoReadFile('48_x86-start16-spl.dts') + data = self._DoReadFile('048_x86-start16-spl.dts') self.assertEqual(X86_START16_SPL_DATA, data[:len(X86_START16_SPL_DATA)]) def _PackUbootSplMicrocode(self, dts, ucode_second=False): @@ -1067,7 +1067,7 @@ class TestFunctional(unittest.TestCase): def testPackUbootSplMicrocode(self): """Test that x86 microcode can be handled correctly in SPL""" - self._PackUbootSplMicrocode('49_x86_ucode_spl.dts') + self._PackUbootSplMicrocode('049_x86_ucode_spl.dts') def testPackUbootSplMicrocodeReorder(self): """Test that order doesn't matter for microcode entries @@ -1076,22 +1076,22 @@ class TestFunctional(unittest.TestCase): u-boot-ucode entry we have not yet seen the u-boot-dtb-with-ucode entry, so we reply on binman to try later. """ - self._PackUbootSplMicrocode('58_x86_ucode_spl_needs_retry.dts', + self._PackUbootSplMicrocode('058_x86_ucode_spl_needs_retry.dts', ucode_second=True) def testPackMrc(self): """Test that an image with an MRC binary can be created""" - data = self._DoReadFile('50_intel_mrc.dts') + data = self._DoReadFile('050_intel_mrc.dts') self.assertEqual(MRC_DATA, data[:len(MRC_DATA)]) def testSplDtb(self): """Test that an image with spl/u-boot-spl.dtb can be created""" - data = self._DoReadFile('51_u_boot_spl_dtb.dts') + data = self._DoReadFile('051_u_boot_spl_dtb.dts') self.assertEqual(U_BOOT_SPL_DTB_DATA, data[:len(U_BOOT_SPL_DTB_DATA)]) def testSplNoDtb(self): """Test that an image with spl/u-boot-spl-nodtb.bin can be created""" - data = self._DoReadFile('52_u_boot_spl_nodtb.dts') + data = self._DoReadFile('052_u_boot_spl_nodtb.dts') self.assertEqual(U_BOOT_SPL_NODTB_DATA, data[:len(U_BOOT_SPL_NODTB_DATA)]) def testSymbols(self): @@ -1102,7 +1102,7 @@ class TestFunctional(unittest.TestCase): self.assertEqual(syms['_binman_u_boot_spl_prop_offset'].address, addr) self._SetupSplElf('u_boot_binman_syms') - data = self._DoReadFile('53_symbols.dts') + data = self._DoReadFile('053_symbols.dts') sym_values = struct.pack('