Browse Source

nand: atmel: Initialize pmecc smu with correct size

Currently in pmecc_get_sigma(), the code tries to clear the memory
pointed by smu with wrong size 'sizeof(int16_t) * ARRAY_SIZE(smu)'.
Since smu is actually a pointer, not an array, so ARRAY_SIZE(smu)
does not generate correct size to be cleared.

In fact, GCC 8.1.0 reports a warning against it:

error: division 'sizeof (int16_t * {aka short int *}) / sizeof (int16_t
{aka short int})' does not compute the number of array elements
[-Werror=sizeof-pointer-div]

Fix it by using the correct size.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Bin Meng 3 years ago
parent
commit
ed5df0852f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/mtd/nand/raw/atmel_nand.c

+ 1 - 1
drivers/mtd/nand/raw/atmel_nand.c

@@ -249,7 +249,7 @@ static void pmecc_get_sigma(struct mtd_info *mtd)
249 249
 	int diff;
250 250
 
251 251
 	/* Init the Sigma(x) */
252
-	memset(smu, 0, sizeof(int16_t) * ARRAY_SIZE(smu));
252
+	memset(smu, 0, sizeof(int16_t) * num * (cap + 2));
253 253
 
254 254
 	dmu_0_count = 0;
255 255