powerpc/mpc8xxx: fix recognition of DIMMs with ECC and Address Parity

To recognize DIMMs with ECC capability by testing ECC bit only. Not to be
confused by Address Parity bit.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
master
York Sun 13 years ago committed by Kumar Gala
parent 55f7934d2b
commit 08b3f7599f
  1. 3
      arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
  2. 4
      arch/powerpc/include/asm/fsl_ddr_dimm_params.h

@ -367,7 +367,8 @@ compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,
/* Determine if all DIMMs ECC capable. */
temp1 = 1;
for (i = 0; i < number_of_dimms; i++) {
if (dimm_params[i].n_ranks && dimm_params[i].edc_config != 2) {
if (dimm_params[i].n_ranks &&
!(dimm_params[i].edc_config & EDC_ECC)) {
temp1 = 0;
break;
}

@ -9,6 +9,10 @@
#ifndef DDR2_DIMM_PARAMS_H
#define DDR2_DIMM_PARAMS_H
#define EDC_DATA_PARITY 1
#define EDC_ECC 2
#define EDC_AC_PARITY 4
/* Parameters for a DDR2 dimm computed from the SPD */
typedef struct dimm_params_s {

Loading…
Cancel
Save