arch/powerpc/cpu/mpc8xxx/: sparse fixes

ctrl_regs.c:31:5: warning: symbol 'fsl_ddr_get_version' was not declared. Should it be static?
cpu.c:135:14: warning: non-ANSI function declaration of function 'cpu_mask'
cpu.c:154:18: warning: non-ANSI function declaration of function 'cpu_numcores'
cpu.c:37:17: warning: symbol 'cpu_type_list' was not declared. Should it be static?
cpu.c:117:17: warning: symbol 'cpu_type_unknown' was not declared. Should it be static?
fsl_lbc.c:14:6: warning: symbol '__lbc_sdram_init' was not declared. Should it be static?

and:

lc_common_dimm_params.c:15:1: warning: symbol 'compute_cas_latency_ddr3' was not declared. Should it be static?

making it static produces the following compiler warning:

lc_common_dimm_params.c:15:1: warning: 'compute_cas_latency_ddr3' defined but not used [-Wunused-function]

so we protect it with the preprocessor.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
master
Kim Phillips 12 years ago committed by Tom Rini
parent 0eb257683d
commit 2ed2e9121f
  1. 9
      arch/powerpc/cpu/mpc8xxx/cpu.c
  2. 2
      arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c
  3. 4
      arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
  4. 2
      arch/powerpc/cpu/mpc8xxx/fsl_lbc.c

@ -34,7 +34,7 @@
DECLARE_GLOBAL_DATA_PTR;
struct cpu_type cpu_type_list [] = {
static struct cpu_type cpu_type_list[] = {
#if defined(CONFIG_MPC85xx)
CPU_TYPE_ENTRY(8533, 8533, 1),
CPU_TYPE_ENTRY(8535, 8535, 1),
@ -125,7 +125,7 @@ u32 compute_ppc_cpumask(void)
#define compute_ppc_cpumask() 1
#endif /* CONFIG_SYS_FSL_QORIQ_CHASSIS2 */
struct cpu_type cpu_type_unknown = CPU_TYPE_ENTRY(Unknown, Unknown, 0);
static struct cpu_type cpu_type_unknown = CPU_TYPE_ENTRY(Unknown, Unknown, 0);
struct cpu_type *identify_cpu(u32 ver)
{
@ -143,7 +143,7 @@ struct cpu_type *identify_cpu(u32 ver)
/*
* Return a 32-bit mask indicating which cores are present on this SOC.
*/
u32 cpu_mask()
u32 cpu_mask(void)
{
ccsr_pic_t __iomem *pic = (void *)CONFIG_SYS_MPC8xxx_PIC_ADDR;
struct cpu_type *cpu = gd->cpu;
@ -162,7 +162,8 @@ u32 cpu_mask()
/*
* Return the number of cores on this SOC.
*/
int cpu_numcores() {
int cpu_numcores(void)
{
struct cpu_type *cpu = gd->cpu;
/*

@ -28,7 +28,7 @@
#error "Undefined _DDR_ADDR"
#endif
u32 fsl_ddr_get_version(void)
static u32 fsl_ddr_get_version(void)
{
ccsr_ddr_t *ddr;
u32 ver_major_minor_errata;

@ -11,7 +11,8 @@
#include "ddr.h"
unsigned int
#if defined(CONFIG_FSL_DDR3)
static unsigned int
compute_cas_latency_ddr3(const dimm_params_t *dimm_params,
common_timing_params_t *outpdimm,
unsigned int number_of_dimms)
@ -65,6 +66,7 @@ compute_cas_latency_ddr3(const dimm_params_t *dimm_params,
return 0;
}
#endif
/*
* compute_lowest_common_dimm_parameters()

@ -11,7 +11,7 @@
#ifdef CONFIG_MPC85xx
/* Boards should provide their own version of this if they use lbc sdram */
void __lbc_sdram_init(void)
static void __lbc_sdram_init(void)
{
/* Do nothing */
}

Loading…
Cancel
Save