dtoc: Put each phandle on a separate line

When writing values from properties which contain phandles, dtoc currently
writes 8 phandles per line. Change this to write one phandle per line.
This helps reduce line length, since phandles are generally longer and may
have arguments.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Kever Yang <kever.yang@rock-chips.com>
master
Simon Glass 7 years ago
parent 0d15463c05
commit 35d503700f
  1. 12
      tools/dtoc/dtb_platdata.py
  2. 3
      tools/dtoc/test_dtoc.py

@ -468,15 +468,17 @@ class DtbPlatdata(object):
target_node = self._fdt.phandle_to_node[phandle]
name = conv_name_to_c(target_node.name)
vals.append('{&%s%s, %d}' % (VAL_PREFIX, name, id_num))
for val in vals:
self.buf('\n\t\t%s,' % val)
else:
for val in prop.value:
vals.append(get_value(prop.type, val))
# Put 8 values per line to avoid very long lines.
for i in xrange(0, len(vals), 8):
if i:
self.buf(',\n\t\t')
self.buf(', '.join(vals[i:i + 8]))
# Put 8 values per line to avoid very long lines.
for i in xrange(0, len(vals), 8):
if i:
self.buf(',\n\t\t')
self.buf(', '.join(vals[i:i + 8]))
self.buf('}')
else:
self.buf(get_value(prop.type, prop.value))

@ -252,7 +252,8 @@ U_BOOT_DEVICE(phandle_target) = {
};
static struct dtd_source dtv_phandle_source = {
\t.clocks\t\t\t= {{&dtv_phandle_target, 1}},
\t.clocks\t\t\t= {
\t\t{&dtv_phandle_target, 1},},
};
U_BOOT_DEVICE(phandle_source) = {
\t.name\t\t= "source",

Loading…
Cancel
Save