cfi_flash: Use u8 pointers instead of void pointers

According to the C standard, pointer arithmetic for pointers of type
void is undefined behavior (the assumption that they're 8-bit wide is a
GCC-specific assumption). In the interest of keeping the code
standards-compliant, and also better communicate intent, switch all
void* variables where pointer arithmetic is used to u8* variables.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
Signed-off-by: Stefan Roese <sr@denx.de>
master
Mario Six 6 years ago committed by Stefan Roese
parent d3525b6bb0
commit 5312838dd5
  1. 8
      drivers/mtd/cfi_flash.c

@ -491,7 +491,7 @@ static int flash_isset(flash_info_t *info, flash_sect_t sect,
static int flash_toggle(flash_info_t *info, flash_sect_t sect,
uint offset, uchar cmd)
{
void *addr;
u8 *addr;
cfiword_t cword;
int retval;
@ -872,9 +872,9 @@ static int flash_write_cfibuffer(flash_info_t *info, ulong dest, uchar *cp,
flash_sect_t sector;
int cnt;
int retcode;
void *src = cp;
void *dst = (void *)dest;
void *dst2 = dst;
u8 *src = cp;
u8 *dst = (u8 *)dest;
u8 *dst2 = dst;
int flag = 1;
uint offset = 0;
unsigned int shift;

Loading…
Cancel
Save