sandbox: eth-raw: Correct valid socket test in send/recv

In open, the socket is correctly checked to be -1 in the error case.
In send and recv, we checked for 0, but that is a valid socket number.

Correct this by checking for -1 as a bad socket everywhere.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
lime2-spi
Joe Hershberger 6 years ago
parent 82a115fdec
commit 97367df109
  1. 4
      arch/sandbox/cpu/eth-raw-os.c

@ -156,7 +156,7 @@ int sandbox_eth_raw_os_send(void *packet, int length,
int retval;
struct udphdr *udph = packet + sizeof(struct iphdr);
if (!priv->sd || !priv->device)
if (priv->sd < 0 || !priv->device)
return -EINVAL;
/*
@ -221,7 +221,7 @@ int sandbox_eth_raw_os_recv(void *packet, int *length,
int retval;
int saddr_size;
if (!priv->sd || !priv->device)
if (priv->sd < 0 || !priv->device)
return -EINVAL;
saddr_size = sizeof(struct sockaddr);
retval = recvfrom(priv->sd, packet, 1536, 0,

Loading…
Cancel
Save