cmd_usage(): simplify return code handling

Lots of code use this construct:

	cmd_usage(cmdtp);
	return 1;

Change cmd_usage() let it return 1 - then we can replace all these
ocurrances by

	return cmd_usage(cmdtp);

This fixes a few places with incorrect return code handling, too.

Signed-off-by: Wolfgang Denk <wd@denx.de>
master
Wolfgang Denk 14 years ago
parent debb6299ac
commit 47e26b1bf9
  1. 6
      arch/powerpc/cpu/mpc512x/diu.c
  2. 10
      arch/powerpc/cpu/mpc8260/bedbug_603e.c
  3. 9
      arch/powerpc/cpu/mpc83xx/ecc.c
  4. 10
      arch/powerpc/cpu/mpc8xx/bedbug_860.c
  5. 6
      board/amcc/acadia/cmd_acadia.c
  6. 3
      board/amcc/luan/luan.c
  7. 13
      board/amcc/makalu/cmd_pll.c
  8. 20
      board/amcc/taihu/lcd.c
  9. 15
      board/amcc/taihu/taihu.c
  10. 20
      board/amcc/taishan/lcd.c
  11. 6
      board/amcc/yucca/cmd_yucca.c
  12. 6
      board/barco/barco.c
  13. 21
      board/digsy_mtc/cmd_mtc.c
  14. 6
      board/esd/common/lcd.c
  15. 4
      board/esd/dasa_sim/cmd_dasa_sim.c
  16. 6
      board/freescale/common/sys_eeprom.c
  17. 6
      board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c
  18. 6
      board/hymod/bsp.c
  19. 18
      board/inka4x0/inkadiag.c
  20. 9
      board/keymile/km_arm/km_arm.c
  21. 6
      board/lwmon/lwmon.c
  22. 17
      board/lwmon5/lwmon5.c
  23. 3
      board/mpl/common/common_util.c
  24. 3
      board/pcippc2/pcippc2.c
  25. 5
      board/pcs440ep/pcs440ep.c
  26. 6
      board/pdm360ng/pdm360ng.c
  27. 27
      board/pn62/cmd_pn62.c
  28. 6
      board/prodrive/pdnb3/pdnb3.c
  29. 12
      board/renesas/sh7785lcr/rtl8169_mac.c
  30. 9
      board/renesas/sh7785lcr/selfcheck.c
  31. 3
      board/siemens/common/fpga.c
  32. 3
      board/siemens/pcu_e/pcu_e.c
  33. 9
      board/spear/common/spr_misc.c
  34. 18
      board/tqc/tqm5200/cmd_stk52xx.c
  35. 67
      board/trab/cmd_trab.c
  36. 25
      board/trizepsiv/eeprom.c
  37. 6
      board/w7o/cmd_vpd.c
  38. 12
      common/cmd_bedbug.c
  39. 14
      common/cmd_bmp.c
  40. 6
      common/cmd_boot.c
  41. 11
      common/cmd_bootm.c
  42. 14
      common/cmd_cache.c
  43. 24
      common/cmd_dcr.c
  44. 3
      common/cmd_df.c
  45. 3
      common/cmd_eeprom.c
  46. 10
      common/cmd_ext2.c
  47. 3
      common/cmd_fdc.c
  48. 3
      common/cmd_fdos.c
  49. 76
      common/cmd_fdt.c
  50. 47
      common/cmd_flash.c
  51. 12
      common/cmd_fpga.c
  52. 87
      common/cmd_i2c.c
  53. 20
      common/cmd_ide.c
  54. 11
      common/cmd_irq.c
  55. 6
      common/cmd_itest.c
  56. 2
      common/cmd_load.c
  57. 6
      common/cmd_log.c
  58. 80
      common/cmd_mem.c
  59. 28
      common/cmd_mfsl.c
  60. 9
      common/cmd_mii.c
  61. 10
      common/cmd_misc.c
  62. 15
      common/cmd_mmc.c
  63. 31
      common/cmd_mp.c
  64. 3
      common/cmd_mtdparts.c
  65. 9
      common/cmd_nand.c
  66. 16
      common/cmd_net.c
  67. 22
      common/cmd_nvedit.c
  68. 30
      common/cmd_onenand.c
  69. 3
      common/cmd_otp.c
  70. 3
      common/cmd_pci.c
  71. 18
      common/cmd_portio.c
  72. 10
      common/cmd_reiser.c
  73. 12
      common/cmd_sata.c
  74. 15
      common/cmd_scsi.c
  75. 6
      common/cmd_setexpr.c
  76. 3
      common/cmd_sf.c
  77. 6
      common/cmd_strings.c
  78. 12
      common/cmd_ubi.c
  79. 25
      common/cmd_ubifs.c
  80. 12
      common/cmd_usb.c
  81. 6
      common/cmd_vfd.c
  82. 2
      common/command.c
  83. 6
      common/hush.c
  84. 6
      common/main.c
  85. 3
      drivers/gpio/pca953x.c
  86. 13
      drivers/misc/ds4510.c
  87. 20
      drivers/misc/fsl_pmic.c
  88. 9
      drivers/qe/qe.c
  89. 49
      tools/updater/cmd_flash.c

@ -111,10 +111,8 @@ int mpc5121diu_init_show_bmp(cmd_tbl_t *cmdtp,
{ {
unsigned int addr; unsigned int addr;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (!strncmp(argv[1], "init", 4)) { if (!strncmp(argv[1], "init", 4)) {
#if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE) #if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE)

@ -71,10 +71,7 @@ void bedbug603e_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
/* -------------------------------------------------- */ /* -------------------------------------------------- */
if (argc < 2) if (argc < 2)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return;
}
/* Turn off a breakpoint */ /* Turn off a breakpoint */
@ -118,10 +115,7 @@ void bedbug603e_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
if(!(( isdigit( argv[ 1 ][ 0 ] )) || if(!(( isdigit( argv[ 1 ][ 0 ] )) ||
(( argv[ 1 ][ 0 ] >= 'a' ) && ( argv[ 1 ][ 0 ] <= 'f' )) || (( argv[ 1 ][ 0 ] >= 'a' ) && ( argv[ 1 ][ 0 ] <= 'f' )) ||
(( argv[ 1 ][ 0 ] >= 'A' ) && ( argv[ 1 ][ 0 ] <= 'F' )))) (( argv[ 1 ][ 0 ] >= 'A' ) && ( argv[ 1 ][ 0 ] <= 'F' ))))
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return;
}
addr = simple_strtoul( argv[ 1 ], NULL, 16 ); addr = simple_strtoul( argv[ 1 ], NULL, 16 );

@ -118,10 +118,8 @@ int do_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
writeback[0] = 0x01234567UL; writeback[0] = 0x01234567UL;
writeback[1] = 0x89abcdefUL; writeback[1] = 0x89abcdefUL;
if (argc > 4) { if (argc > 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (argc == 2) { if (argc == 2) {
if (strcmp(argv[1], "status") == 0) { if (strcmp(argv[1], "status") == 0) {
@ -350,8 +348,7 @@ int do_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD(ecc, 4, 0, do_ecc, U_BOOT_CMD(ecc, 4, 0, do_ecc,

@ -70,10 +70,7 @@ void bedbug860_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
/* -------------------------------------------------- */ /* -------------------------------------------------- */
if (argc < 2) if (argc < 2)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return;
}
/* Turn off a breakpoint */ /* Turn off a breakpoint */
@ -121,10 +118,7 @@ void bedbug860_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
/* Set a breakpoint at the address */ /* Set a breakpoint at the address */
if( !isdigit( argv[ 1 ][ 0 ])) if( !isdigit( argv[ 1 ][ 0 ]))
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return;
}
addr = simple_strtoul( argv[ 1 ], NULL, 16 ) & 0xfffffffc; addr = simple_strtoul( argv[ 1 ], NULL, 16 ) & 0xfffffffc;

@ -44,10 +44,8 @@ static int do_bootstrap(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[
u8 *buf; u8 *buf;
int cpu_freq; int cpu_freq;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
cpu_freq = simple_strtol(argv[1], NULL, 10); cpu_freq = simple_strtol(argv[1], NULL, 10);
if (cpu_freq != 267) { if (cpu_freq != 267) {

@ -223,8 +223,7 @@ int do_l2cache( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[] )
l2cache_status() ? "ON" : "OFF"); l2cache_status() ? "ON" : "OFF");
return 0; return 0;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -182,14 +182,14 @@ do_pll_alter (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
char c = '\0'; char c = '\0';
pll_freq_t pll_freq; pll_freq_t pll_freq;
if (argc < 2) {
cmd_usage(cmdtp);
goto ret;
}
for (pll_freq = PLL_ebc20; pll_freq < PLL_TOTAL; pll_freq++) if (argc < 2)
return cmd_usage(cmdtp);
for (pll_freq = PLL_ebc20; pll_freq < PLL_TOTAL; pll_freq++) {
if (!strcmp(pll_name[pll_freq], argv[1])) if (!strcmp(pll_name[pll_freq], argv[1]))
break; break;
}
switch (pll_freq) { switch (pll_freq) {
case PLL_ebc20: case PLL_ebc20:
@ -223,8 +223,7 @@ do_pll_alter (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
default: default:
printf("Invalid options\n\n"); printf("Invalid options\n\n");
cmd_usage(cmdtp); return cmd_usage(cmdtp);
goto ret;
} }
printf("PLL set to %s, " printf("PLL set to %s, "

@ -139,10 +139,9 @@ static int do_lcd_clear (cmd_tbl_t * cmdtp, int flag, int argc, char * const arg
static int do_lcd_puts (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) static int do_lcd_puts (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
lcd_puts(argv[1]); lcd_puts(argv[1]);
return 0; return 0;
@ -150,10 +149,9 @@ static int do_lcd_puts (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv
static int do_lcd_putc (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) static int do_lcd_putc (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
lcd_putc((char)argv[1][0]); lcd_putc((char)argv[1][0]);
return 0; return 0;
@ -165,10 +163,8 @@ static int do_lcd_cur (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[
ulong dir; ulong dir;
char cur_addr; char cur_addr;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
count = simple_strtoul(argv[1], NULL, 16); count = simple_strtoul(argv[1], NULL, 16);
if (count > 31) { if (count > 31) {

@ -101,16 +101,12 @@ static int do_led_ctl(cmd_tbl_t* cmd_tp, int flags, int argc, char * const argv[
{ {
int led_no; int led_no;
if (argc != 3) { if (argc != 3)
cmd_usage(cmd_tp); return cmd_usage(cmd_tp);
return -1;
}
led_no = simple_strtoul(argv[1], NULL, 16); led_no = simple_strtoul(argv[1], NULL, 16);
if (led_no != 1 && led_no != 2) { if (led_no != 1 && led_no != 2)
cmd_usage(cmd_tp); return cmd_usage(cmd_tp);
return -1;
}
if (strcmp(argv[2],"off") == 0x0) { if (strcmp(argv[2],"off") == 0x0) {
if (led_no == 1) if (led_no == 1)
@ -123,8 +119,7 @@ static int do_led_ctl(cmd_tbl_t* cmd_tp, int flags, int argc, char * const argv[
else else
gpio_write_bit(31, 0); gpio_write_bit(31, 0);
} else { } else {
cmd_usage(cmd_tp); return cmd_usage(cmd_tp);
return -1;
} }
return 0; return 0;

@ -166,19 +166,17 @@ static int do_lcd_clear(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv
} }
static int do_lcd_puts(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) static int do_lcd_puts(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
lcd_puts(argv[1]); lcd_puts(argv[1]);
return 0; return 0;
} }
static int do_lcd_putc(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) static int do_lcd_putc(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
lcd_putc((char)argv[1][0]); lcd_putc((char)argv[1][0]);
return 0; return 0;
} }
@ -188,10 +186,8 @@ static int do_lcd_cur(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]
ulong dir; ulong dir;
char cur_addr; char cur_addr;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
count = simple_strtoul(argv[1], NULL, 16); count = simple_strtoul(argv[1], NULL, 16);
if (count > 31) { if (count > 31) {

@ -58,10 +58,8 @@ static int setBootStrapClock(cmd_tbl_t *cmdtp, int incrflag, int flag,
char plbClock[4]; char plbClock[4];
char pcixClock[4]; char pcixClock[4];
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[2], "prom0") == 0) if (strcmp(argv[2], "prom0") == 0)
chip = IIC0_BOOTPROM_ADDR; chip = IIC0_BOOTPROM_ADDR;

@ -290,12 +290,6 @@ void barcobcd_boot (void)
int barcobcd_boot_image (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int barcobcd_boot_image (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
#if 0
if (argc > 1) {
cmd_usage(cmdtp);
return 1;
}
#endif
barcobcd_boot (); barcobcd_boot ();
return 0; return 0;

@ -75,10 +75,8 @@ static int do_mtc_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int err; int err;
int i; int i;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
memset(&pcmd, 0, sizeof(pcmd)); memset(&pcmd, 0, sizeof(pcmd));
memset(&prx, 0, sizeof(prx)); memset(&prx, 0, sizeof(prx));
@ -149,10 +147,8 @@ static int do_mtc_digout(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv
int err; int err;
uchar channel_mask = 0; uchar channel_mask = 0;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
if (strncmp(argv[1], "on", 2) == 0) if (strncmp(argv[1], "on", 2) == 0)
channel_mask |= 1; channel_mask |= 1;
@ -178,10 +174,8 @@ static int do_mtc_digin(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[
int err; int err;
uchar channel_num = 0; uchar channel_num = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
channel_num = simple_strtol(argv[1], NULL, 10); channel_num = simple_strtol(argv[1], NULL, 10);
if ((channel_num != 1) && (channel_num != 2)) { if ((channel_num != 1) && (channel_num != 2)) {
@ -332,8 +326,7 @@ int cmd_mtc(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return c->cmd(c, flag, argc, argv); return c->cmd(c, flag, argc, argv);
} else { } else {
/* Unrecognized command */ /* Unrecognized command */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return err; return err;

@ -345,10 +345,8 @@ int do_esdbmp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#ifdef CONFIG_VIDEO_SM501 #ifdef CONFIG_VIDEO_SM501
char *str; char *str;
#endif #endif
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);

@ -221,9 +221,7 @@ int do_pci9054 (cmd_tbl_t * cmdtp, int flag, int argc,
return 0; return 0;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -351,8 +351,7 @@ int do_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
prog_eeprom(); prog_eeprom();
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
break;
} }
return 0; return 0;
@ -388,8 +387,7 @@ int do_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
break; break;
case 'h': /* help */ case 'h': /* help */
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
break;
} }
return 0; return 0;

@ -115,10 +115,8 @@ int mpc8610diu_init_show_bmp(cmd_tbl_t *cmdtp,
{ {
unsigned int addr; unsigned int addr;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (!strncmp(argv[1],"init",4)) { if (!strncmp(argv[1],"init",4)) {
#if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE) #if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE)

@ -272,8 +272,7 @@ do_fpga (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
break; break;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(
fpga, 6, 1, do_fpga, fpga, 6, 1, do_fpga,
@ -324,8 +323,7 @@ do_eecl (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
/* fall through ... */ /* fall through ... */
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
memset (data, 0, HYMOD_EEPROM_SIZE); memset (data, 0, HYMOD_EEPROM_SIZE);

@ -168,8 +168,7 @@ static int do_inkadiag_io(cmd_tbl_t *cmdtp, int flag, int argc,
printf("exit code: 0x%X\n", val); printf("exit code: 0x%X\n", val);
return 0; return 0;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
break;
} }
return -1; return -1;
@ -244,10 +243,8 @@ static int do_inkadiag_serial(cmd_tbl_t *cmdtp, int flag, int argc,
int combrd, baudrate, i, j, len; int combrd, baudrate, i, j, len;
int address; int address;
if (argc < 5) { if (argc < 5)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
argc--; argc--;
argv++; argv++;
@ -394,10 +391,8 @@ static int do_inkadiag_buzzer(cmd_tbl_t *cmdtp, int flag, int argc,
unsigned int period, freq; unsigned int period, freq;
int prev, i; int prev, i;
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
argc--; argc--;
argv++; argv++;
@ -474,8 +469,7 @@ static int do_inkadiag(cmd_tbl_t *cmdtp, int flag, int argc,
return c->cmd(c, flag, argc, argv); return c->cmd(c, flag, argc, argv);
} else { } else {
/* Unrecognized command */ /* Unrecognized command */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
} }

@ -186,10 +186,8 @@ int board_init(void)
int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
u32 tmp; u32 tmp;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((strcmp(argv[1], "off") == 0)) { if ((strcmp(argv[1], "off") == 0)) {
printf("SPI FLASH disabled, NAND enabled\n"); printf("SPI FLASH disabled, NAND enabled\n");
@ -214,8 +212,7 @@ int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
tmp = readl(KW_GPIO0_BASE); tmp = readl(KW_GPIO0_BASE);
writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE); writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE);
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -845,8 +845,7 @@ int do_pic (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
default: default:
break; break;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(
pic, 4, 1, do_pic, pic, 4, 1, do_pic,
@ -975,8 +974,7 @@ int do_lsb (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
default: default:
break; break;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -306,20 +306,15 @@ void hw_watchdog_reset(void)
int do_eeprom_wp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_eeprom_wp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((strcmp(argv[1], "on") == 0)) { if ((strcmp(argv[1], "on") == 0))
gpio_write_bit(CONFIG_SYS_GPIO_EEPROM_EXT_WP, 1); gpio_write_bit(CONFIG_SYS_GPIO_EEPROM_EXT_WP, 1);
} else if ((strcmp(argv[1], "off") == 0)) { else if ((strcmp(argv[1], "off") == 0))
gpio_write_bit(CONFIG_SYS_GPIO_EEPROM_EXT_WP, 0); gpio_write_bit(CONFIG_SYS_GPIO_EEPROM_EXT_WP, 0);
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
return 0; return 0;
} }

@ -528,8 +528,7 @@ int do_mplcommon(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
#endif #endif
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }

@ -232,8 +232,7 @@ int do_wd (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
default: default:
break; break;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -616,9 +616,8 @@ int do_sha1 (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int rcode = -1; int rcode = -1;
if (argc < 2) { if (argc < 2) {
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (argc >= 3) { if (argc >= 3) {

@ -635,10 +635,8 @@ static int set_lcd_brightness(char *brightness)
static int cmd_lcd_brightness(cmd_tbl_t *cmdtp, int flag, static int cmd_lcd_brightness(cmd_tbl_t *cmdtp, int flag,
int argc, char * const argv[]) int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
return set_lcd_brightness(argv[1]); return set_lcd_brightness(argv[1]);
} }

@ -36,20 +36,20 @@ extern int do_bootm (cmd_tbl_t *, int, int, char *[]);
/* /*
* Command led: controls the various LEDs 0..11 on the PN62 card. * Command led: controls the various LEDs 0..11 on the PN62 card.
*/ */
int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_led(cmd_tbl_t * cmdtp, int flag, int argc, char *const argv[])
{ {
unsigned int number, function; unsigned int number, function;
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} number = simple_strtoul(argv[1], NULL, 10);
number = simple_strtoul(argv[1], NULL, 10); if (number > PN62_LED_MAX)
if (number > PN62_LED_MAX) return 1;
return 1;
function = simple_strtoul(argv[2], NULL, 16); function = simple_strtoul(argv[2], NULL, 16);
set_led (number, function); set_led(number, function);
return 0; return 0;
} }
U_BOOT_CMD( U_BOOT_CMD(
led , 3, 1, do_led, led , 3, 1, do_led,
@ -83,8 +83,7 @@ int do_loadpci (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
printf ("## Ready for image download ...\n"); printf ("## Ready for image download ...\n");

@ -214,10 +214,8 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
ulong addr; ulong addr;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);

@ -304,10 +304,8 @@ int do_set_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
unsigned char mac[6]; unsigned char mac[6];
char *s, *e; char *s, *e;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
s = argv[1]; s = argv[1];
@ -330,10 +328,8 @@ U_BOOT_CMD(
int do_print_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_print_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc != 1) { if (argc != 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
mac_read(); mac_read();

@ -112,10 +112,8 @@ int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
char *cmd; char *cmd;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
cmd = argv[1]; cmd = argv[1];
switch (cmd[0]) { switch (cmd[0]) {
@ -150,8 +148,7 @@ int do_hw_test(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
test_net(); test_net();
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -286,8 +286,7 @@ int do_fpga (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
failure: failure:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -399,8 +399,7 @@ int do_puma (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
default: default:
break; break;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD (puma, 4, 1, do_puma, U_BOOT_CMD (puma, 4, 1, do_puma,

@ -215,10 +215,8 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
char *s, *e; char *s, *e;
char i2c_mac[20]; char i2c_mac[20];
if ((argc > 3) || (argc < 2)) { if ((argc > 3) || (argc < 2))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((!strcmp(argv[1], "cpufreq")) || (!strcmp(argv[1], "ddrfreq"))) { if ((!strcmp(argv[1], "cpufreq")) || (!strcmp(argv[1], "ddrfreq"))) {
@ -286,8 +284,7 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD(chip_config, 3, 1, do_chip_config, U_BOOT_CMD(chip_config, 3, 1, do_chip_config,

@ -327,8 +327,7 @@ static int cmd_sound(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
switch (argc) { switch (argc) {
case 0: case 0:
case 1: case 1:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 2: case 2:
if (strncmp(argv[1],"saw",3) == 0) { if (strncmp(argv[1],"saw",3) == 0) {
printf ("Play sawtooth\n"); printf ("Play sawtooth\n");
@ -342,8 +341,7 @@ static int cmd_sound(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return rcode; return rcode;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 3: case 3:
if (strncmp(argv[1],"saw",3) == 0) { if (strncmp(argv[1],"saw",3) == 0) {
duration = simple_strtoul(argv[2], NULL, 10); duration = simple_strtoul(argv[2], NULL, 10);
@ -358,8 +356,7 @@ static int cmd_sound(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
LEFT_RIGHT); LEFT_RIGHT);
return rcode; return rcode;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 4: case 4:
if (strncmp(argv[1],"saw",3) == 0) { if (strncmp(argv[1],"saw",3) == 0) {
duration = simple_strtoul(argv[2], NULL, 10); duration = simple_strtoul(argv[2], NULL, 10);
@ -382,8 +379,7 @@ static int cmd_sound(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
pcm1772_write_reg((uchar)reg, (uchar)val); pcm1772_write_reg((uchar)reg, (uchar)val);
return 0; return 0;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 5: case 5:
if (strncmp(argv[1],"saw",3) == 0) { if (strncmp(argv[1],"saw",3) == 0) {
duration = simple_strtoul(argv[2], NULL, 10); duration = simple_strtoul(argv[2], NULL, 10);
@ -412,8 +408,7 @@ static int cmd_sound(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
channel); channel);
return rcode; return rcode;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
printf ("Usage:\nsound cmd [arg1] [arg2] ...\n"); printf ("Usage:\nsound cmd [arg1] [arg2] ...\n");
return 1; return 1;
@ -513,8 +508,7 @@ static int cmd_beep(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
channel = LEFT_RIGHT; channel = LEFT_RIGHT;
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if ((tmp = getenv ("volume")) != NULL) { if ((tmp = getenv ("volume")) != NULL) {

@ -167,10 +167,8 @@ int do_burn_in (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int i; int i;
int cycle_status; int cycle_status;
if (argc > 1) { if (argc > 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
led_init (); led_init ();
global_vars_init (); global_vars_init ();
@ -270,14 +268,11 @@ int do_dip (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
int i, dip; int i, dip;
if (argc > 1) { if (argc > 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((dip = read_dip ()) == -1) { if ((dip = read_dip ()) == -1)
return 1; return 1;
}
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
if ((dip & (1 << i)) == 0) if ((dip & (1 << i)) == 0)
@ -303,14 +298,11 @@ int do_vcc5v (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
int vcc5v; int vcc5v;
if (argc > 1) { if (argc > 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((vcc5v = read_vcc5v ()) == -1) { if ((vcc5v = read_vcc5v ()) == -1)
return (1); return (1);
}
printf ("%d", (vcc5v / 1000)); printf ("%d", (vcc5v / 1000));
printf (".%d", (vcc5v % 1000) / 100); printf (".%d", (vcc5v % 1000) / 100);
@ -331,10 +323,8 @@ int do_contact_temp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
int contact_temp; int contact_temp;
if (argc > 1) { if (argc > 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
tsc2000_spi_init (); tsc2000_spi_init ();
@ -354,36 +344,32 @@ U_BOOT_CMD(
int do_burn_in_status (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_burn_in_status (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc > 1) { if (argc > 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_STATUS, 1, if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_STATUS, 1,
(unsigned char*) &status, 1)) { (unsigned char*) &status, 1))
return (1); return (1);
}
if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_PASS_CYCLES, 1, if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_PASS_CYCLES, 1,
(unsigned char*) &pass_cycles, 2)) { (unsigned char*) &pass_cycles, 2))
return (1); return (1);
}
if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_CYCLE, if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_CYCLE,
1, (unsigned char*) &first_error_cycle, 2)) { 1, (unsigned char*) &first_error_cycle, 2))
return (1); return (1);
}
if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_NUM, if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_NUM,
1, (unsigned char*) &first_error_num, 1)) { 1, (unsigned char*) &first_error_num, 1))
return (1); return (1);
}
if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_NAME, if (i2c_read_multiple (I2C_EEPROM_DEV_ADDR, EE_ADDR_FIRST_ERROR_NAME,
1, (unsigned char*)first_error_name, 1, (unsigned char*)first_error_name,
sizeof (first_error_name))) { sizeof (first_error_name)))
return (1); return (1);
}
if (read_max_cycles () != 0) { if (read_max_cycles () != 0)
return (1); return (1);
}
printf ("max_cycles = %d\n", max_cycles); printf ("max_cycles = %d\n", max_cycles);
printf ("status = %d\n", status); printf ("status = %d\n", status);
@ -850,14 +836,11 @@ int do_temp_log (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
struct rtc_time tm; struct rtc_time tm;
#endif #endif
if (argc > 2) { if (argc > 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (argc > 1) { if (argc > 1)
delay = simple_strtoul(argv[1], NULL, 10); delay = simple_strtoul(argv[1], NULL, 10);
}
tsc2000_spi_init (); tsc2000_spi_init ();
while (1) { while (1) {

@ -42,36 +42,29 @@ static int do_read_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char *
static int do_write_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { static int do_write_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
int offset,value; int offset,value;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
offset=simple_strtoul(argv[2],NULL,16); offset=simple_strtoul(argv[2],NULL,16);
value=simple_strtoul(argv[3],NULL,16); value=simple_strtoul(argv[3],NULL,16);
if (offset > 0x40) { if (offset > 0x40) {
printf("Wrong offset : 0x%x\n",offset); printf("Wrong offset : 0x%x\n",offset);
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
dm9000_write_srom_word(offset, value); dm9000_write_srom_word(offset, value);
return (0); return (0);
} }
int do_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { int do_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp (argv[1],"read") == 0) { if (strcmp (argv[1],"read") == 0)
return (do_read_dm9000_eeprom(cmdtp,flag,argc,argv)); return (do_read_dm9000_eeprom(cmdtp,flag,argc,argv));
} else if (strcmp (argv[1],"write") == 0) { else if (strcmp (argv[1],"write") == 0)
return (do_write_dm9000_eeprom(cmdtp,flag,argc,argv)); return (do_write_dm9000_eeprom(cmdtp,flag,argc,argv));
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -38,10 +38,8 @@ int do_vpd (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
uchar dev_addr = CONFIG_SYS_DEF_EEPROM_ADDR; uchar dev_addr = CONFIG_SYS_DEF_EEPROM_ADDR;
/* Validate usage */ /* Validate usage */
if (argc > 2) { if (argc > 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Passed in EEPROM address */ /* Passed in EEPROM address */
if (argc == 2) if (argc == 2)

@ -84,10 +84,8 @@ int do_bedbug_dis (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
addr = dis_last_addr; addr = dis_last_addr;
len = dis_last_len; len = dis_last_len;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
/* New command */ /* New command */
@ -125,10 +123,8 @@ int do_bedbug_asm (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
/* -------------------------------------------------- */ /* -------------------------------------------------- */
int rcode = 0; int rcode = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
printf ("\nEnter '.' when done\n"); printf ("\nEnter '.' when done\n");
mem_addr = simple_strtoul (argv[1], NULL, 16); mem_addr = simple_strtoul (argv[1], NULL, 16);

@ -102,8 +102,7 @@ static int do_bmp_info(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return (bmp_info(addr)); return (bmp_info(addr));
@ -127,8 +126,7 @@ static int do_bmp_display(cmd_tbl_t * cmdtp, int flag, int argc, char * const ar
y = simple_strtoul(argv[3], NULL, 10); y = simple_strtoul(argv[3], NULL, 10);
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return (bmp_display(addr, x, y)); return (bmp_display(addr, x, y));
@ -159,12 +157,10 @@ static int do_bmp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
c = find_cmd_tbl(argv[0], &cmd_bmp_sub[0], ARRAY_SIZE(cmd_bmp_sub)); c = find_cmd_tbl(argv[0], &cmd_bmp_sub[0], ARRAY_SIZE(cmd_bmp_sub));
if (c) { if (c)
return c->cmd(cmdtp, flag, argc, argv); return c->cmd(cmdtp, flag, argc, argv);
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -40,10 +40,8 @@ int do_go (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ulong addr, rc; ulong addr, rc;
int rcode = 0; int rcode = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);

@ -491,17 +491,14 @@ int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv
argv++; argv++;
return bootm_start(cmdtp, flag, argc, argv); return bootm_start(cmdtp, flag, argc, argv);
} }
} } else {
/* Unrecognized command */ /* Unrecognized command */
else { return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return 1;
} }
if (images.state >= state) { if (images.state >= state) {
printf ("Trying to execute a command out of order\n"); printf ("Trying to execute a command out of order\n");
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
images.state |= state; images.state |= state;

@ -34,10 +34,6 @@ int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
switch (argc) { switch (argc) {
case 2: /* on / off */ case 2: /* on / off */
switch (on_off(argv[1])) { switch (on_off(argv[1])) {
#if 0 /* prevented by varargs handling; FALLTROUGH is harmless, too */
default: cmd_usage(cmdtp);
return;
#endif
case 0: icache_disable(); case 0: icache_disable();
break; break;
case 1: icache_enable (); case 1: icache_enable ();
@ -49,8 +45,7 @@ int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
icache_status() ? "ON" : "OFF"); icache_status() ? "ON" : "OFF");
return 0; return 0;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;
} }
@ -60,10 +55,6 @@ int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
switch (argc) { switch (argc) {
case 2: /* on / off */ case 2: /* on / off */
switch (on_off(argv[1])) { switch (on_off(argv[1])) {
#if 0 /* prevented by varargs handling; FALLTROUGH is harmless, too */
default: cmd_usage(cmdtp);
return;
#endif
case 0: dcache_disable(); case 0: dcache_disable();
break; break;
case 1: dcache_enable (); case 1: dcache_enable ();
@ -75,8 +66,7 @@ int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
dcache_status() ? "ON" : "OFF"); dcache_status() ? "ON" : "OFF");
return 0; return 0;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -44,10 +44,8 @@ int do_getdcr ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[] )
unsigned long get_dcr (unsigned short); unsigned long get_dcr (unsigned short);
/* Validate arguments */ /* Validate arguments */
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Get a DCR */ /* Get a DCR */
dcrn = (unsigned short) simple_strtoul (argv[1], NULL, 16); dcrn = (unsigned short) simple_strtoul (argv[1], NULL, 16);
@ -73,10 +71,8 @@ int do_setdcr (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
extern char console_buffer[]; extern char console_buffer[];
/* Validate arguments */ /* Validate arguments */
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Set a DCR */ /* Set a DCR */
dcrn = (unsigned short) simple_strtoul (argv[1], NULL, 16); dcrn = (unsigned short) simple_strtoul (argv[1], NULL, 16);
@ -120,10 +116,8 @@ int do_getidcr (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
char buf[80]; char buf[80];
/* Validate arguments */ /* Validate arguments */
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Find out whether ther is '.' (dot) symbol in the first parameter. */ /* Find out whether ther is '.' (dot) symbol in the first parameter. */
strncpy (buf, argv[1], sizeof(buf)-1); strncpy (buf, argv[1], sizeof(buf)-1);
@ -176,10 +170,8 @@ int do_setidcr (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
char buf[80]; char buf[80];
/* Validate arguments */ /* Validate arguments */
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Find out whether ther is '.' (dot) symbol in the first parameter. */ /* Find out whether ther is '.' (dot) symbol in the first parameter. */
strncpy (buf, argv[1], sizeof(buf)-1); strncpy (buf, argv[1], sizeof(buf)-1);

@ -27,8 +27,7 @@ static int do_df(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -104,8 +104,7 @@ int do_eeprom ( cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
#endif #endif

@ -65,10 +65,9 @@ int do_ext2ls (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
block_dev_desc_t *dev_desc=NULL; block_dev_desc_t *dev_desc=NULL;
int part_length; int part_length;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
dev = (int)simple_strtoul (argv[2], &ep, 16); dev = (int)simple_strtoul (argv[2], &ep, 16);
dev_desc = get_dev(argv[1],dev); dev_desc = get_dev(argv[1],dev);
@ -164,8 +163,7 @@ int do_ext2load (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (!filename) { if (!filename) {

@ -741,8 +741,7 @@ int do_fdcboot (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
boot_drive=simple_strtoul(argv[2], NULL, 10); boot_drive=simple_strtoul(argv[2], NULL, 10);
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/* setup FDC and scan for drives */ /* setup FDC and scan for drives */
if(fdc_setup(boot_drive,pCMD,pFG)==FALSE) { if(fdc_setup(boot_drive,pCMD,pFG)==FALSE) {

@ -73,8 +73,7 @@ int do_fdosboot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
name = argv [2]; name = argv [2];
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
break;
} }
/* Init physical layer */ /* Init physical layer */

@ -65,14 +65,12 @@ void set_working_fdt_addr(void *addr)
*/ */
int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/******************************************************************** /*
* Set the address of the fdt * Set the address of the fdt
********************************************************************/ */
if (argv[1][0] == 'a') { if (argv[1][0] == 'a') {
unsigned long addr; unsigned long addr;
/* /*
@ -116,18 +114,16 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
} }
/******************************************************************** /*
* Move the working_fdt * Move the working_fdt
********************************************************************/ */
} else if (strncmp(argv[1], "mo", 2) == 0) { } else if (strncmp(argv[1], "mo", 2) == 0) {
struct fdt_header *newaddr; struct fdt_header *newaddr;
int len; int len;
int err; int err;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Set the address and length of the fdt. * Set the address and length of the fdt.
@ -166,9 +162,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
working_fdt = newaddr; working_fdt = newaddr;
/******************************************************************** /*
* Make a new node * Make a new node
********************************************************************/ */
} else if (strncmp(argv[1], "mk", 2) == 0) { } else if (strncmp(argv[1], "mk", 2) == 0) {
char *pathp; /* path */ char *pathp; /* path */
char *nodep; /* new node to add */ char *nodep; /* new node to add */
@ -178,10 +174,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
/* /*
* Parameters: Node path, new node to be appended to the path. * Parameters: Node path, new node to be appended to the path.
*/ */
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
pathp = argv[2]; pathp = argv[2];
nodep = argv[3]; nodep = argv[3];
@ -202,9 +196,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
return 1; return 1;
} }
/******************************************************************** /*
* Set the value of a property in the working_fdt. * Set the value of a property in the working_fdt.
********************************************************************/ */
} else if (argv[1][0] == 's') { } else if (argv[1][0] == 's') {
char *pathp; /* path */ char *pathp; /* path */
char *prop; /* property */ char *prop; /* property */
@ -216,10 +210,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
/* /*
* Parameters: Node path, property, optional value. * Parameters: Node path, property, optional value.
*/ */
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
pathp = argv[2]; pathp = argv[2];
prop = argv[3]; prop = argv[3];
@ -247,9 +239,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
return 1; return 1;
} }
/******************************************************************** /*
* Print (recursive) / List (single level) * Print (recursive) / List (single level)
********************************************************************/ */
} else if ((argv[1][0] == 'p') || (argv[1][0] == 'l')) { } else if ((argv[1][0] == 'p') || (argv[1][0] == 'l')) {
int depth = MAX_LEVEL; /* how deep to print */ int depth = MAX_LEVEL; /* how deep to print */
char *pathp; /* path */ char *pathp; /* path */
@ -281,9 +273,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
if (ret != 0) if (ret != 0)
return ret; return ret;
/******************************************************************** /*
* Remove a property/node * Remove a property/node
********************************************************************/ */
} else if (strncmp(argv[1], "rm", 2) == 0) { } else if (strncmp(argv[1], "rm", 2) == 0) {
int nodeoffset; /* node offset from libfdt */ int nodeoffset; /* node offset from libfdt */
int err; int err;
@ -321,9 +313,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
} }
/******************************************************************** /*
* Display header info * Display header info
********************************************************************/ */
} else if (argv[1][0] == 'h') { } else if (argv[1][0] == 'h') {
u32 version = fdt_version(working_fdt); u32 version = fdt_version(working_fdt);
printf("magic:\t\t\t0x%x\n", fdt_magic(working_fdt)); printf("magic:\t\t\t0x%x\n", fdt_magic(working_fdt));
@ -351,16 +343,16 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
fdt_num_mem_rsv(working_fdt)); fdt_num_mem_rsv(working_fdt));
printf("\n"); printf("\n");
/******************************************************************** /*
* Set boot cpu id * Set boot cpu id
********************************************************************/ */
} else if (strncmp(argv[1], "boo", 3) == 0) { } else if (strncmp(argv[1], "boo", 3) == 0) {
unsigned long tmp = simple_strtoul(argv[2], NULL, 16); unsigned long tmp = simple_strtoul(argv[2], NULL, 16);
fdt_set_boot_cpuid_phys(working_fdt, tmp); fdt_set_boot_cpuid_phys(working_fdt, tmp);
/******************************************************************** /*
* memory command * memory command
********************************************************************/ */
} else if (strncmp(argv[1], "me", 2) == 0) { } else if (strncmp(argv[1], "me", 2) == 0) {
uint64_t addr, size; uint64_t addr, size;
int err; int err;
@ -370,9 +362,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
if (err < 0) if (err < 0)
return err; return err;
/******************************************************************** /*
* mem reserve commands * mem reserve commands
********************************************************************/ */
} else if (strncmp(argv[1], "rs", 2) == 0) { } else if (strncmp(argv[1], "rs", 2) == 0) {
if (argv[2][0] == 'p') { if (argv[2][0] == 'p') {
uint64_t addr, size; uint64_t addr, size;
@ -417,8 +409,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
} else { } else {
/* Unrecognized command */ /* Unrecognized command */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
} }
#ifdef CONFIG_OF_BOARD_SETUP #ifdef CONFIG_OF_BOARD_SETUP
@ -430,10 +421,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
else if (argv[1][0] == 'c') { else if (argv[1][0] == 'c') {
unsigned long initrd_start = 0, initrd_end = 0; unsigned long initrd_start = 0, initrd_end = 0;
if ((argc != 2) && (argc != 4)) { if ((argc != 2) && (argc != 4))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (argc == 4) { if (argc == 4) {
initrd_start = simple_strtoul(argv[2], NULL, 16); initrd_start = simple_strtoul(argv[2], NULL, 16);
@ -449,8 +438,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
} }
else { else {
/* Unrecognized command */ /* Unrecognized command */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -332,10 +332,8 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#endif #endif
int rcode = 0; int rcode = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "all") == 0) { if (strcmp(argv[1], "all") == 0) {
for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) { for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) {
@ -383,10 +381,8 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
#endif #endif
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "bank") == 0) { if (strcmp(argv[1], "bank") == 0) {
bank = simple_strtoul(argv[2], NULL, 16); bank = simple_strtoul(argv[2], NULL, 16);
@ -406,10 +402,8 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 1; return 1;
} }
if (addr_first >= addr_last) { if (addr_first >= addr_last)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
rcode = flash_sect_erase(addr_first, addr_last); rcode = flash_sect_erase(addr_first, addr_last);
return rcode; return rcode;
@ -482,19 +476,15 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int p; int p;
int rcode = 0; int rcode = 0;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "off") == 0) { if (strcmp(argv[1], "off") == 0)
p = 0; p = 0;
} else if (strcmp(argv[1], "on") == 0) { else if (strcmp(argv[1], "on") == 0)
p = 1; p = 1;
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
#ifdef CONFIG_HAS_DATAFLASH #ifdef CONFIG_HAS_DATAFLASH
if ((strcmp(argv[2], "all") != 0) && (strcmp(argv[2], "bank") != 0)) { if ((strcmp(argv[2], "all") != 0) && (strcmp(argv[2], "bank") != 0)) {
@ -592,10 +582,8 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
#endif #endif
if (argc != 4) { if (argc != 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[2], "bank") == 0) { if (strcmp(argv[2], "bank") == 0) {
bank = simple_strtoul(argv[3], NULL, 16); bank = simple_strtoul(argv[3], NULL, 16);
@ -634,10 +622,9 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 1; return 1;
} }
if (addr_first >= addr_last) { if (addr_first >= addr_last)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
rcode = flash_sect_protect (p, addr_first, addr_last); rcode = flash_sect_protect (p, addr_first, addr_last);
#endif /* CONFIG_SYS_NO_FLASH */ #endif /* CONFIG_SYS_NO_FLASH */
return rcode; return rcode;

@ -44,7 +44,6 @@
#endif #endif
/* Local functions */ /* Local functions */
static void fpga_usage (cmd_tbl_t * cmdtp);
static int fpga_get_op (char *opstr); static int fpga_get_op (char *opstr);
/* Local defines */ /* Local defines */
@ -232,8 +231,7 @@ int do_fpga (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
switch (op) { switch (op) {
case FPGA_NONE: case FPGA_NONE:
fpga_usage (cmdtp); return cmd_usage(cmdtp);
break;
case FPGA_INFO: case FPGA_INFO:
rc = fpga_info (dev); rc = fpga_info (dev);
@ -312,17 +310,11 @@ int do_fpga (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
default: default:
printf ("Unknown operation\n"); printf ("Unknown operation\n");
fpga_usage (cmdtp); return cmd_usage(cmdtp);
break;
} }
return (rc); return (rc);
} }
static void fpga_usage (cmd_tbl_t * cmdtp)
{
cmd_usage(cmdtp);
}
/* /*
* Map op to supported operations. We don't use a table since we * Map op to supported operations. We don't use a table since we
* would just have to relocate it from flash anyway. * would just have to relocate it from flash anyway.

@ -184,10 +184,8 @@ static int do_i2c_read ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv
uint devaddr, alen, length; uint devaddr, alen, length;
u_char *memaddr; u_char *memaddr;
if (argc != 5) { if (argc != 5)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* I2C chip address * I2C chip address
@ -200,10 +198,8 @@ static int do_i2c_read ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv
*/ */
devaddr = simple_strtoul(argv[2], NULL, 16); devaddr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Length is the number of objects, not number of bytes. * Length is the number of objects, not number of bytes.
@ -240,10 +236,8 @@ static int do_i2c_md ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
alen = i2c_dp_last_alen; alen = i2c_dp_last_alen;
length = i2c_dp_last_length; length = i2c_dp_last_length;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
/* /*
@ -261,10 +255,8 @@ static int do_i2c_md ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
*/ */
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* If another parameter, it is the length to display. * If another parameter, it is the length to display.
@ -332,10 +324,8 @@ static int do_i2c_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
uchar byte; uchar byte;
int count; int count;
if ((argc < 4) || (argc > 5)) { if ((argc < 4) || (argc > 5))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Chip is always specified. * Chip is always specified.
@ -347,10 +337,8 @@ static int do_i2c_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
*/ */
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Value to write is always specified. * Value to write is always specified.
@ -398,10 +386,8 @@ static int do_i2c_crc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
ulong crc; ulong crc;
ulong err; ulong err;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Chip is always specified. * Chip is always specified.
@ -413,10 +399,8 @@ static int do_i2c_crc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
*/ */
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Count is always specified * Count is always specified
@ -462,10 +446,8 @@ mod_i2c_mem(cmd_tbl_t *cmdtp, int incrflag, int flag, int argc, char * const arg
int nbytes; int nbytes;
extern char console_buffer[]; extern char console_buffer[];
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
#ifdef CONFIG_BOOT_RETRY_TIME #ifdef CONFIG_BOOT_RETRY_TIME
reset_cmd_timeout(); /* got a good command to get here */ reset_cmd_timeout(); /* got a good command to get here */
@ -495,10 +477,8 @@ mod_i2c_mem(cmd_tbl_t *cmdtp, int incrflag, int flag, int argc, char * const arg
*/ */
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
/* /*
@ -628,10 +608,8 @@ static int do_i2c_loop(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
u_char bytes[16]; u_char bytes[16];
int delay; int delay;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Chip is always specified. * Chip is always specified.
@ -643,10 +621,8 @@ static int do_i2c_loop(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]
*/ */
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
alen = get_alen(argv[2]); alen = get_alen(argv[2]);
if (alen == 0) { if (alen == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Length is the number of objects, not number of bytes. * Length is the number of objects, not number of bytes.
@ -784,10 +760,9 @@ static int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
"32 MiB", "16 MiB", "8 MiB", "4 MiB" "32 MiB", "16 MiB", "8 MiB", "4 MiB"
}; };
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* /*
* Chip is always specified. * Chip is always specified.
*/ */
@ -1322,12 +1297,10 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
c = find_cmd_tbl(argv[0], &cmd_i2c_sub[0], ARRAY_SIZE(cmd_i2c_sub)); c = find_cmd_tbl(argv[0], &cmd_i2c_sub[0], ARRAY_SIZE(cmd_i2c_sub));
if (c) { if (c)
return c->cmd(cmdtp, flag, argc, argv); return c->cmd(cmdtp, flag, argc, argv);
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
/***************************************************/ /***************************************************/

@ -179,8 +179,7 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
switch (argc) { switch (argc) {
case 0: case 0:
case 1: case 1:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 2: case 2:
if (strncmp(argv[1],"res",3) == 0) { if (strncmp(argv[1],"res",3) == 0) {
puts ("\nReset IDE" puts ("\nReset IDE"
@ -229,8 +228,7 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
return rcode; return rcode;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 3: case 3:
if (strncmp(argv[1],"dev",3) == 0) { if (strncmp(argv[1],"dev",3) == 0) {
int dev = (int)simple_strtoul(argv[2], NULL, 10); int dev = (int)simple_strtoul(argv[2], NULL, 10);
@ -278,8 +276,7 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#endif #endif
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
default: default:
/* at least 4 args */ /* at least 4 args */
@ -332,14 +329,12 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
printf ("%ld blocks written: %s\n", printf ("%ld blocks written: %s\n",
n, (n==cnt) ? "OK" : "ERROR"); n, (n==cnt) ? "OK" : "ERROR");
if (n==cnt) { if (n==cnt)
return 0; return 0;
} else { else
return 1; return 1;
}
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
rcode = 1;
} }
return rcode; return rcode;
@ -374,9 +369,8 @@ int do_diskboot (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
boot_device = argv[2]; boot_device = argv[2];
break; break;
default: default:
cmd_usage(cmdtp);
show_boot_progress (-42); show_boot_progress (-42);
return 1; return cmd_usage(cmdtp);
} }
show_boot_progress (42); show_boot_progress (42);

@ -27,17 +27,14 @@
int do_interrupts(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_interrupts(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* on */ /* on */
if (strncmp(argv[1], "on", 2) == 0) { if (strncmp(argv[1], "on", 2) == 0)
enable_interrupts(); enable_interrupts();
} else { else
disable_interrupts(); disable_interrupts();
}
return 0; return 0;
} }

@ -165,10 +165,8 @@ int do_itest ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[] )
int value, w; int value, w;
/* Validate arguments */ /* Validate arguments */
if ((argc != 4)){ if ((argc != 4))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for a data width specification. /* Check for a data width specification.
* Defaults to long (4) if no specification. * Defaults to long (4) if no specification.

@ -1102,7 +1102,7 @@ int do_hwflow (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (strcmp(argv[1], "on") == 0) if (strcmp(argv[1], "on") == 0)
hwflow_onoff(1); hwflow_onoff(1);
else else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
} }
printf("RTS/CTS hardware flow control: %s\n", hwflow_onoff(0) ? "on" : "off"); printf("RTS/CTS hardware flow control: %s\n", hwflow_onoff(0) ? "on" : "off");
return 0; return 0;

@ -241,12 +241,10 @@ int do_log (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
return 0; return 0;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
} }

@ -76,10 +76,8 @@ int do_mem_md ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
size = dp_last_size; size = dp_last_size;
length = dp_last_length; length = dp_last_length;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
/* New command specified. Check for a size specification. /* New command specified. Check for a size specification.
@ -172,10 +170,8 @@ int do_mem_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ulong addr, writeval, count; ulong addr, writeval, count;
int size; int size;
if ((argc < 3) || (argc > 4)) { if ((argc < 3) || (argc > 4))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for size specification. /* Check for size specification.
*/ */
@ -216,10 +212,8 @@ int do_mem_mdc ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int i; int i;
ulong count; ulong count;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
count = simple_strtoul(argv[3], NULL, 10); count = simple_strtoul(argv[3], NULL, 10);
@ -245,10 +239,8 @@ int do_mem_mwc ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int i; int i;
ulong count; ulong count;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
count = simple_strtoul(argv[3], NULL, 10); count = simple_strtoul(argv[3], NULL, 10);
@ -276,10 +268,8 @@ int do_mem_cmp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int size; int size;
int rcode = 0; int rcode = 0;
if (argc != 4) { if (argc != 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for size specification. /* Check for size specification.
*/ */
@ -360,10 +350,8 @@ int do_mem_cp ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ulong addr, dest, count; ulong addr, dest, count;
int size; int size;
if (argc != 4) { if (argc != 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for size specification. /* Check for size specification.
*/ */
@ -484,10 +472,8 @@ int do_mem_loop (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
volatile ushort *shortp; volatile ushort *shortp;
volatile u_char *cp; volatile u_char *cp;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for a size spefication. /* Check for a size spefication.
* Defaults to long if no or incorrect specification. * Defaults to long if no or incorrect specification.
@ -555,10 +541,8 @@ int do_mem_loopw (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
volatile ushort *shortp; volatile ushort *shortp;
volatile u_char *cp; volatile u_char *cp;
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check for a size spefication. /* Check for a size spefication.
* Defaults to long if no or incorrect specification. * Defaults to long if no or incorrect specification.
@ -990,10 +974,8 @@ mod_mem(cmd_tbl_t *cmdtp, int incrflag, int flag, int argc, char * const argv[])
int nbytes, size; int nbytes, size;
extern char console_buffer[]; extern char console_buffer[];
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
#ifdef CONFIG_BOOT_RETRY_TIME #ifdef CONFIG_BOOT_RETRY_TIME
reset_cmd_timeout(); /* got a good command to get here */ reset_cmd_timeout(); /* got a good command to get here */
@ -1095,10 +1077,8 @@ int do_mem_crc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ulong crc; ulong crc;
ulong *ptr; ulong *ptr;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul (argv[1], NULL, 16); addr = simple_strtoul (argv[1], NULL, 16);
addr += base_address; addr += base_address;
@ -1131,9 +1111,8 @@ int do_mem_crc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
char * const *av; char * const *av;
if (argc < 3) { if (argc < 3) {
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
av = argv + 1; av = argv + 1;
@ -1181,10 +1160,8 @@ int do_md5sum(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
unsigned int i; unsigned int i;
u8 output[16]; u8 output[16];
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);
len = simple_strtoul(argv[2], NULL, 16); len = simple_strtoul(argv[2], NULL, 16);
@ -1206,10 +1183,8 @@ int do_sha1sum(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
unsigned int i; unsigned int i;
u8 output[20]; u8 output[20];
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[1], NULL, 16); addr = simple_strtoul(argv[1], NULL, 16);
len = simple_strtoul(argv[2], NULL, 16); len = simple_strtoul(argv[2], NULL, 16);
@ -1239,8 +1214,7 @@ int do_unzip ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
dst = simple_strtoul(argv[2], NULL, 16); dst = simple_strtoul(argv[2], NULL, 16);
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return !!gunzip((void *) dst, dst_len, (void *) src, &src_len); return !!gunzip((void *) dst, dst_len, (void *) src, &src_len);

@ -37,17 +37,14 @@ int do_frd (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
unsigned int num; unsigned int num;
unsigned int blocking; unsigned int blocking;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
fslnum = (unsigned int)simple_strtoul (argv[1], NULL, 16); fslnum = (unsigned int)simple_strtoul (argv[1], NULL, 16);
blocking = (unsigned int)simple_strtoul (argv[2], NULL, 16); blocking = (unsigned int)simple_strtoul (argv[2], NULL, 16);
if (fslnum < 0 || fslnum >= XILINX_FSL_NUMBER) { if (fslnum < 0 || fslnum >= XILINX_FSL_NUMBER) {
puts ("Bad number of FSL\n"); puts ("Bad number of FSL\n");
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
switch (fslnum) { switch (fslnum) {
@ -195,18 +192,14 @@ int do_fwr (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
unsigned int num; unsigned int num;
unsigned int blocking; unsigned int blocking;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
fslnum = (unsigned int)simple_strtoul (argv[1], NULL, 16); fslnum = (unsigned int)simple_strtoul (argv[1], NULL, 16);
num = (unsigned int)simple_strtoul (argv[2], NULL, 16); num = (unsigned int)simple_strtoul (argv[2], NULL, 16);
blocking = (unsigned int)simple_strtoul (argv[3], NULL, 16); blocking = (unsigned int)simple_strtoul (argv[3], NULL, 16);
if (fslnum < 0 || fslnum >= XILINX_FSL_NUMBER) { if (fslnum < 0 || fslnum >= XILINX_FSL_NUMBER)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
switch (fslnum) { switch (fslnum) {
#if (XILINX_FSL_NUMBER > 0) #if (XILINX_FSL_NUMBER > 0)
@ -353,10 +346,9 @@ int do_rspr (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
unsigned int reg = 0; unsigned int reg = 0;
unsigned int val = 0; unsigned int val = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
reg = (unsigned int)simple_strtoul (argv[1], NULL, 16); reg = (unsigned int)simple_strtoul (argv[1], NULL, 16);
val = (unsigned int)simple_strtoul (argv[2], NULL, 16); val = (unsigned int)simple_strtoul (argv[2], NULL, 16);
switch (reg) { switch (reg) {

@ -301,10 +301,8 @@ int do_mii (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
int rcode = 0; int rcode = 0;
char *devname; char *devname;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
#if defined(CONFIG_MII_INIT) #if defined(CONFIG_MII_INIT)
mii_init (); mii_init ();
@ -431,8 +429,7 @@ int do_mii (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
else else
miiphy_set_current_dev (argv[2]); miiphy_set_current_dev (argv[2]);
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/* /*

@ -32,17 +32,15 @@ int do_sleep (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
ulong start = get_timer(0); ulong start = get_timer(0);
ulong delay; ulong delay;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
delay = simple_strtoul(argv[1], NULL, 10) * CONFIG_SYS_HZ; delay = simple_strtoul(argv[1], NULL, 10) * CONFIG_SYS_HZ;
while (get_timer(start) < delay) { while (get_timer(start) < delay) {
if (ctrlc ()) { if (ctrlc ())
return (-1); return (-1);
}
udelay (100); udelay (100);
} }

@ -32,10 +32,8 @@ int do_mmc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
int dev; int dev;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "init") == 0) { if (strcmp(argv[1], "init") == 0) {
if (argc == 2) { if (argc == 2) {
@ -46,8 +44,7 @@ int do_mmc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} else if (argc == 3) { } else if (argc == 3) {
dev = (int)simple_strtoul(argv[2], NULL, 10); dev = (int)simple_strtoul(argv[2], NULL, 10);
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (mmc_legacy_init(dev) != 0) { if (mmc_legacy_init(dev) != 0) {
@ -72,14 +69,12 @@ int do_mmc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#endif #endif
curr_device = dev; curr_device = dev;
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
printf("mmc%d is current device\n", curr_device); printf("mmc%d is current device\n", curr_device);
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
return 0; return 0;

@ -28,10 +28,8 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
unsigned long cpuid; unsigned long cpuid;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
cpuid = simple_strtoul(argv[1], NULL, 10); cpuid = simple_strtoul(argv[1], NULL, 10);
if (cpuid >= cpu_numcores()) { if (cpuid >= cpu_numcores()) {
@ -42,29 +40,24 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (argc == 3) { if (argc == 3) {
if (strncmp(argv[2], "reset", 5) == 0) { if (strncmp(argv[2], "reset", 5) == 0)
cpu_reset(cpuid); cpu_reset(cpuid);
} else if (strncmp(argv[2], "status", 6) == 0) { else if (strncmp(argv[2], "status", 6) == 0)
cpu_status(cpuid); cpu_status(cpuid);
} else if (strncmp(argv[2], "disable", 7) == 0) { else if (strncmp(argv[2], "disable", 7) == 0)
return cpu_disable(cpuid); return cpu_disable(cpuid);
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
return 0; return 0;
} }
/* 4 or greater, make sure its release */ /* 4 or greater, make sure its release */
if (strncmp(argv[2], "release", 7) != 0) { if (strncmp(argv[2], "release", 7) != 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (cpu_release(cpuid, argc - 3, argv + 3)) { if (cpu_release(cpuid, argc - 3, argv + 3))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
return 0; return 0;
} }

@ -1845,8 +1845,7 @@ int do_mtdparts(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return delete_partition(argv[2]); return delete_partition(argv[2]);
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/***************************************************/ /***************************************************/

@ -275,8 +275,7 @@ int do_nand_env_oob(cmd_tbl_t *cmdtp, nand_info_t *nand,
return ret; return ret;
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
#endif #endif
@ -577,8 +576,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
#endif #endif
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD(nand, CONFIG_SYS_MAXARGS, 1, do_nand, U_BOOT_CMD(nand, CONFIG_SYS_MAXARGS, 1, do_nand,
@ -759,9 +757,8 @@ int do_nandboot(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
#if defined(CONFIG_CMD_MTDPARTS) #if defined(CONFIG_CMD_MTDPARTS)
usage: usage:
#endif #endif
cmd_usage(cmdtp);
show_boot_progress(-53); show_boot_progress(-53);
return 1; return cmd_usage(cmdtp);
} }
show_boot_progress(53); show_boot_progress(53);

@ -186,9 +186,9 @@ netboot_common (proto_t proto, cmd_tbl_t *cmdtp, int argc, char * const argv[])
break; break;
default: cmd_usage(cmdtp); default:
show_boot_progress (-80); show_boot_progress (-80);
return 1; return cmd_usage(cmdtp);
} }
show_boot_progress (80); show_boot_progress (80);
@ -236,10 +236,8 @@ int do_ping (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return -1; return -1;
NetPingIP = string_to_ip(argv[1]); NetPingIP = string_to_ip(argv[1]);
if (NetPingIP == 0) { if (NetPingIP == 0)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
if (NetLoop(PING) < 0) { if (NetLoop(PING) < 0) {
printf("ping failed; host %s is not alive\n", argv[1]); printf("ping failed; host %s is not alive\n", argv[1]);
@ -342,10 +340,8 @@ U_BOOT_CMD(
#if defined(CONFIG_CMD_DNS) #if defined(CONFIG_CMD_DNS)
int do_dns(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_dns(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc == 1) { if (argc == 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
/* /*
* We should check for a valid hostname: * We should check for a valid hostname:

@ -407,10 +407,8 @@ void forceenv (char *varname, char *varvalue)
int do_setenv (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_setenv (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
return _do_setenv (flag, argc, argv); return _do_setenv (flag, argc, argv);
} }
@ -433,15 +431,13 @@ int do_askenv ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
local_args[2] = NULL; local_args[2] = NULL;
local_args[3] = NULL; local_args[3] = NULL;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Check the syntax */ /* Check the syntax */
switch (argc) { switch (argc) {
case 1: case 1:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 2: /* askenv envname */ case 2: /* askenv envname */
sprintf (message, "Please enter '%s':", argv[1]); sprintf (message, "Please enter '%s':", argv[1]);
@ -503,10 +499,8 @@ int do_editenv(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
char *init_val; char *init_val;
int len; int len;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* Set read buffer to initial value or empty sting */ /* Set read buffer to initial value or empty sting */
init_val = getenv(argv[1]); init_val = getenv(argv[1]);

@ -361,10 +361,7 @@ static int do_onenand_read(cmd_tbl_t * cmdtp, int flag, int argc, char * const a
size_t retlen = 0; size_t retlen = 0;
if (argc < 3) if (argc < 3)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return 1;
}
s = strchr(argv[0], '.'); s = strchr(argv[0], '.');
if ((s != NULL) && (!strcmp(s, ".oob"))) if ((s != NULL) && (!strcmp(s, ".oob")))
@ -391,10 +388,7 @@ static int do_onenand_write(cmd_tbl_t * cmdtp, int flag, int argc, char * const
size_t retlen = 0; size_t retlen = 0;
if (argc < 3) if (argc < 3)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return 1;
}
addr = (ulong)simple_strtoul(argv[1], NULL, 16); addr = (ulong)simple_strtoul(argv[1], NULL, 16);
@ -477,10 +471,7 @@ static int do_onenand_dump(cmd_tbl_t * cmdtp, int flag, int argc, char * const a
char *s; char *s;
if (argc < 2) if (argc < 2)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return 1;
}
s = strchr(argv[0], '.'); s = strchr(argv[0], '.');
ofs = (int)simple_strtoul(argv[1], NULL, 16); ofs = (int)simple_strtoul(argv[1], NULL, 16);
@ -502,10 +493,7 @@ static int do_onenand_markbad(cmd_tbl_t * cmdtp, int flag, int argc, char * cons
argv += 2; argv += 2;
if (argc <= 0) if (argc <= 0)
{ return cmd_usage(cmdtp);
cmd_usage(cmdtp);
return 1;
}
while (argc > 0) { while (argc > 0) {
addr = simple_strtoul(*argv, NULL, 16); addr = simple_strtoul(*argv, NULL, 16);
@ -549,12 +537,10 @@ static int do_onenand(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]
c = find_cmd_tbl(argv[0], &cmd_onenand_sub[0], ARRAY_SIZE(cmd_onenand_sub)); c = find_cmd_tbl(argv[0], &cmd_onenand_sub[0], ARRAY_SIZE(cmd_onenand_sub));
if (c) { if (c)
return c->cmd(cmdtp, flag, argc, argv); return c->cmd(cmdtp, flag, argc, argv);
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -88,8 +88,7 @@ int do_otp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (argc < 4) { if (argc < 4) {
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
prompt_user = false; prompt_user = false;

@ -534,8 +534,7 @@ int do_pci (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 1; return 1;
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/***************************************************/ /***************************************************/

@ -43,13 +43,12 @@ int do_portio_out (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
uint size = out_last_size; uint size = out_last_size;
uint value = out_last_value; uint value = out_last_value;
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
/* New command specified. Check for a size specification. /*
* New command specified. Check for a size specification.
* Defaults to long if no or incorrect specification. * Defaults to long if no or incorrect specification.
*/ */
size = cmd_get_data_size (argv[0], 1); size = cmd_get_data_size (argv[0], 1);
@ -102,13 +101,12 @@ int do_portio_in (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
uint addr = in_last_addr; uint addr = in_last_addr;
uint size = in_last_size; uint size = in_last_size;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
/* New command specified. Check for a size specification. /*
* New command specified. Check for a size specification.
* Defaults to long if no or incorrect specification. * Defaults to long if no or incorrect specification.
*/ */
size = cmd_get_data_size (argv[0], 1); size = cmd_get_data_size (argv[0], 1);

@ -56,10 +56,9 @@ int do_reiserls (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
block_dev_desc_t *dev_desc=NULL; block_dev_desc_t *dev_desc=NULL;
int part_length; int part_length;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
dev = (int)simple_strtoul (argv[2], &ep, 16); dev = (int)simple_strtoul (argv[2], &ep, 16);
dev_desc = get_dev(argv[1],dev); dev_desc = get_dev(argv[1],dev);
@ -150,8 +149,7 @@ int do_reiserload (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (!filename) { if (!filename) {

@ -77,8 +77,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
switch (argc) { switch (argc) {
case 0: case 0:
case 1: case 1:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 2: case 2:
if (strncmp(argv[1],"inf", 3) == 0) { if (strncmp(argv[1],"inf", 3) == 0) {
int i; int i;
@ -115,8 +114,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
return rc; return rc;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 3: case 3:
if (strncmp(argv[1], "dev", 3) == 0) { if (strncmp(argv[1], "dev", 3) == 0) {
int dev = (int)simple_strtoul(argv[2], NULL, 10); int dev = (int)simple_strtoul(argv[2], NULL, 10);
@ -147,8 +145,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
return rc; return rc;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
default: /* at least 4 args */ default: /* at least 4 args */
if (strcmp(argv[1], "read") == 0) { if (strcmp(argv[1], "read") == 0) {
@ -184,8 +181,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
n, (n == cnt) ? "OK" : "ERROR"); n, (n == cnt) ? "OK" : "ERROR");
return (n == cnt) ? 0 : 1; return (n == cnt) ? 0 : 1;
} else { } else {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
rc = 1;
} }
return rc; return rc;

@ -229,8 +229,7 @@ int do_scsiboot (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
boot_device = argv[2]; boot_device = argv[2];
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (!boot_device) { if (!boot_device) {
@ -346,7 +345,8 @@ int do_scsi (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
switch (argc) { switch (argc) {
case 0: case 0:
case 1: cmd_usage(cmdtp); return 1; case 1: return cmd_usage(cmdtp);
case 2: case 2:
if (strncmp(argv[1],"res",3) == 0) { if (strncmp(argv[1],"res",3) == 0) {
printf("\nReset SCSI\n"); printf("\nReset SCSI\n");
@ -392,8 +392,7 @@ int do_scsi (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
printf("\nno SCSI devices available\n"); printf("\nno SCSI devices available\n");
return 1; return 1;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
case 3: case 3:
if (strncmp(argv[1],"dev",3) == 0) { if (strncmp(argv[1],"dev",3) == 0) {
int dev = (int)simple_strtoul(argv[2], NULL, 10); int dev = (int)simple_strtoul(argv[2], NULL, 10);
@ -421,8 +420,7 @@ int do_scsi (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
} }
return 1; return 1;
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
default: default:
/* at least 4 args */ /* at least 4 args */
if (strcmp(argv[1],"read") == 0) { if (strcmp(argv[1],"read") == 0) {
@ -437,8 +435,7 @@ int do_scsi (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
} /* switch */ } /* switch */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/**************************************************************************************** /****************************************************************************************

@ -57,10 +57,8 @@ int do_setexpr(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int w; int w;
/* Validate arguments */ /* Validate arguments */
if ((argc != 5) || (strlen(argv[3]) != 1)) { if ((argc != 5) || (strlen(argv[3]) != 1))
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
w = cmd_get_data_size(argv[0], 4); w = cmd_get_data_size(argv[0], 4);

@ -177,8 +177,7 @@ static int do_spi_flash(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[
return do_spi_flash_erase(argc - 1, argv + 1); return do_spi_flash_erase(argc - 1, argv + 1);
usage: usage:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -14,10 +14,8 @@ static char *start_addr, *last_addr;
int do_strings(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int do_strings(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
if (argc == 1) { if (argc == 1)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((flag & CMD_FLAG_REPEAT) == 0) { if ((flag & CMD_FLAG_REPEAT) == 0) {
start_addr = (char *)simple_strtoul(argv[1], NULL, 16); start_addr = (char *)simple_strtoul(argv[1], NULL, 16);

@ -442,10 +442,8 @@ static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
ulong addr = 0; ulong addr = 0;
int err = 0; int err = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (mtdparts_init() != 0) { if (mtdparts_init() != 0) {
printf("Error initializing mtdparts!\n"); printf("Error initializing mtdparts!\n");
@ -471,10 +469,8 @@ static int do_ubi(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
/* todo: get dev number for NAND... */ /* todo: get dev number for NAND... */
ubi_dev.nr = 0; ubi_dev.nr = 0;

@ -47,10 +47,9 @@ int do_ubifs_mount(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
char *vol_name; char *vol_name;
int ret; int ret;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
vol_name = argv[1]; vol_name = argv[1];
debug("Using volume %s\n", vol_name); debug("Using volume %s\n", vol_name);
@ -102,25 +101,19 @@ int do_ubifs_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return -1; return -1;
} }
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
addr = simple_strtoul(argv[1], &endp, 16); addr = simple_strtoul(argv[1], &endp, 16);
if (endp == argv[1]) { if (endp == argv[1])
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
filename = argv[2]; filename = argv[2];
if (argc == 4) { if (argc == 4) {
size = simple_strtoul(argv[3], &endp, 16); size = simple_strtoul(argv[3], &endp, 16);
if (endp == argv[3]) { if (endp == argv[3])
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
} }
debug("Loading file '%s' to address 0x%08x (size %d)\n", filename, addr, size); debug("Loading file '%s' to address 0x%08x (size %d)\n", filename, addr, size);

@ -376,8 +376,7 @@ int do_usbboot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
boot_device = argv[2]; boot_device = argv[2];
break; break;
default: default:
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
if (!boot_device) { if (!boot_device) {
@ -516,10 +515,8 @@ int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
block_dev_desc_t *stor_dev; block_dev_desc_t *stor_dev;
#endif #endif
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if ((strncmp(argv[1], "reset", 5) == 0) || if ((strncmp(argv[1], "reset", 5) == 0) ||
(strncmp(argv[1], "start", 5) == 0)) { (strncmp(argv[1], "start", 5) == 0)) {
@ -699,8 +696,7 @@ int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return 0; return 0;
} }
#endif /* CONFIG_USB_STORAGE */ #endif /* CONFIG_USB_STORAGE */
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
#ifdef CONFIG_USB_STORAGE #ifdef CONFIG_USB_STORAGE

@ -49,10 +49,8 @@ int do_vfd (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
ulong bitmap; ulong bitmap;
if (argc != 2) { if (argc != 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (argv[1][0] == '/') { /* select bitmap by number */ if (argv[1][0] == '/') { /* select bitmap by number */
bitmap = simple_strtoul(argv[1]+1, NULL, 10); bitmap = simple_strtoul(argv[1]+1, NULL, 10);

@ -153,7 +153,7 @@ int cmd_usage(cmd_tbl_t *cmdtp)
puts (cmdtp->help); puts (cmdtp->help);
putc ('\n'); putc ('\n');
#endif /* CONFIG_SYS_LONGHELP */ #endif /* CONFIG_SYS_LONGHELP */
return 0; return 1;
} }
#ifdef CONFIG_AUTO_COMPLETE #ifdef CONFIG_AUTO_COMPLETE

@ -1694,10 +1694,8 @@ static int run_pipe_real(struct pipe *pi)
} }
#endif #endif
/* found - check max args */ /* found - check max args */
if ((child->argc - i) > cmdtp->maxargs) { if ((child->argc - i) > cmdtp->maxargs)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return -1;
}
#endif #endif
child->argv+=i; /* XXX horrible hack */ child->argv+=i; /* XXX horrible hack */
#ifndef __U_BOOT__ #ifndef __U_BOOT__

@ -1418,10 +1418,8 @@ int do_run (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
{ {
int i; int i;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
for (i=1; i<argc; ++i) { for (i=1; i<argc; ++i) {
char *arg; char *arg;

@ -164,8 +164,7 @@ int do_pca953x(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (!c || !((argc == (c->maxargs)) || if (!c || !((argc == (c->maxargs)) ||
(((int)c->cmd == PCA953X_CMD_DEVICE) && (((int)c->cmd == PCA953X_CMD_DEVICE) &&
(argc == (c->maxargs - 1))))) { (argc == (c->maxargs - 1))))) {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/* arg2 used as chip number or pin number */ /* arg2 used as chip number or pin number */

@ -294,8 +294,7 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (!c || !((argc == (c->maxargs)) || if (!c || !((argc == (c->maxargs)) ||
(((int)c->cmd == DS4510_CMD_DEVICE) && (((int)c->cmd == DS4510_CMD_DEVICE) &&
(argc == (c->maxargs - 1))))) { (argc == (c->maxargs - 1))))) {
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
/* arg2 used as chip addr and pin number */ /* arg2 used as chip addr and pin number */
@ -366,14 +365,12 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#ifdef CONFIG_CMD_DS4510_MEM #ifdef CONFIG_CMD_DS4510_MEM
/* Only eeprom, seeprom, and sram commands should make it here */ /* Only eeprom, seeprom, and sram commands should make it here */
if (strcmp(argv[2], "read") == 0) { if (strcmp(argv[2], "read") == 0)
rw_func = ds4510_mem_read; rw_func = ds4510_mem_read;
} else if (strcmp(argv[2], "write") == 0) { else if (strcmp(argv[2], "write") == 0)
rw_func = ds4510_mem_write; rw_func = ds4510_mem_write;
} else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
addr = simple_strtoul(argv[3], NULL, 16); addr = simple_strtoul(argv[3], NULL, 16);
off += simple_strtoul(argv[4], NULL, 16); off += simple_strtoul(argv[4], NULL, 16);

@ -163,26 +163,22 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
u32 val; u32 val;
/* at least two arguments please */ /* at least two arguments please */
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
cmd = argv[1]; cmd = argv[1];
if (strcmp(cmd, "dump") == 0) { if (strcmp(cmd, "dump") == 0) {
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
nregs = simple_strtoul(argv[2], NULL, 16); nregs = simple_strtoul(argv[2], NULL, 16);
pmic_dump(nregs); pmic_dump(nregs);
return 0; return 0;
} }
if (strcmp(cmd, "write") == 0) { if (strcmp(cmd, "write") == 0) {
if (argc < 4) { if (argc < 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
nregs = simple_strtoul(argv[2], NULL, 16); nregs = simple_strtoul(argv[2], NULL, 16);
val = simple_strtoul(argv[3], NULL, 16); val = simple_strtoul(argv[3], NULL, 16);
pmic_reg_write(nregs, val); pmic_reg_write(nregs, val);

@ -440,10 +440,8 @@ static int qe_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{ {
ulong addr; ulong addr;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "fw") == 0) { if (strcmp(argv[1], "fw") == 0) {
addr = simple_strtoul(argv[2], NULL, 16); addr = simple_strtoul(argv[2], NULL, 16);
@ -471,8 +469,7 @@ static int qe_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return qe_upload_firmware((const struct qe_firmware *) addr); return qe_upload_firmware((const struct qe_firmware *) addr);
} }
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} }
U_BOOT_CMD( U_BOOT_CMD(

@ -121,10 +121,8 @@ int do_flerase(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
int n, sect_first, sect_last; int n, sect_first, sect_last;
int rcode = 0; int rcode = 0;
if (argc < 2) { if (argc < 2)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "all") == 0) { if (strcmp(argv[1], "all") == 0) {
for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) { for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) {
@ -146,10 +144,8 @@ int do_flerase(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
return rcode; return rcode;
} }
if (argc != 3) { if (argc != 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "bank") == 0) { if (strcmp(argv[1], "bank") == 0) {
bank = simple_strtoul(argv[2], NULL, 16); bank = simple_strtoul(argv[2], NULL, 16);
@ -167,10 +163,8 @@ int do_flerase(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
addr_first = simple_strtoul(argv[1], NULL, 16); addr_first = simple_strtoul(argv[1], NULL, 16);
addr_last = simple_strtoul(argv[2], NULL, 16); addr_last = simple_strtoul(argv[2], NULL, 16);
if (addr_first >= addr_last) { if (addr_first >= addr_last)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
printf ("Erase Flash from 0x%08lx to 0x%08lx ", addr_first, addr_last); printf ("Erase Flash from 0x%08lx to 0x%08lx ", addr_first, addr_last);
rcode = flash_sect_erase(addr_first, addr_last); rcode = flash_sect_erase(addr_first, addr_last);
@ -243,19 +237,15 @@ int do_protect(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
int i, p, n, sect_first, sect_last; int i, p, n, sect_first, sect_last;
int rcode = 0; int rcode = 0;
if (argc < 3) { if (argc < 3)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[1], "off") == 0) if (strcmp(argv[1], "off") == 0)
p = 0; p = 0;
else if (strcmp(argv[1], "on") == 0) else if (strcmp(argv[1], "on") == 0)
p = 1; p = 1;
else { else
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[2], "all") == 0) { if (strcmp(argv[2], "all") == 0) {
for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) { for (bank=1; bank<=CONFIG_SYS_MAX_FLASH_BANKS; ++bank) {
@ -309,10 +299,8 @@ int do_protect(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
return rcode; return rcode;
} }
if (argc != 4) { if (argc != 4)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
}
if (strcmp(argv[2], "bank") == 0) { if (strcmp(argv[2], "bank") == 0) {
bank = simple_strtoul(argv[3], NULL, 16); bank = simple_strtoul(argv[3], NULL, 16);
@ -340,7 +328,8 @@ int do_protect(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
} }
#if defined(CONFIG_SYS_FLASH_PROTECTION) #if defined(CONFIG_SYS_FLASH_PROTECTION)
if (!rcode) puts (" done\n"); if (!rcode)
puts(" done\n");
#endif /* CONFIG_SYS_FLASH_PROTECTION */ #endif /* CONFIG_SYS_FLASH_PROTECTION */
return rcode; return rcode;
@ -349,12 +338,10 @@ int do_protect(cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
addr_first = simple_strtoul(argv[2], NULL, 16); addr_first = simple_strtoul(argv[2], NULL, 16);
addr_last = simple_strtoul(argv[3], NULL, 16); addr_last = simple_strtoul(argv[3], NULL, 16);
if (addr_first >= addr_last) { if (addr_first >= addr_last)
cmd_usage(cmdtp); return cmd_usage(cmdtp);
return 1;
} return flash_sect_protect (p, addr_first, addr_last);
rcode = flash_sect_protect (p, addr_first, addr_last);
return rcode;
} }
int flash_sect_protect (int p, ulong addr_first, ulong addr_last) int flash_sect_protect (int p, ulong addr_first, ulong addr_last)
{ {

Loading…
Cancel
Save